[jira] [Commented] (THRIFT-2028) Cleanup threading headers / libraries

["Jens Geyer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13794466#comment-13794466 ] 

Jens Geyer commented on THRIFT-2028:
------------------------------------

Patch does not (or no longer) apply, even after EOL conversion I get one error in BoostThreadFactory.cpp line 76.

{code}
error: patch failed: lib/cpp/src/thrift/concurrency/BoostThreadFactory.cpp:76
error: lib/cpp/src/thrift/concurrency/BoostThreadFactory.cpp: patch does not apply
{code}


> Cleanup threading headers / libraries
> -------------------------------------
>
>                 Key: THRIFT-2028
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2028
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Library
>    Affects Versions: 0.9
>            Reporter: Ben Craig
>            Assignee: Ben Craig
>             Fix For: 1.0
>
>         Attachments: thread_cleanup.patch
>
>
> The current threading implementations have some minor annoyances:
> All do some amount of internal state tracking with an enum that ends up being overkill.
> All use weak_ptrs to help manage lifetimes, instead of the enable_shared_from_this base class that was designed for exactly this purpose.
> All of the specific thread factories implement "detached" methods, but the base thread factory doesn't have virtual methods exposing the detached methods.
> The thread manager has an unused local.
> Adding a "UniqueGuard" class to Mutex.h, to give more flexible RAII management to locks.  Currently no clients of this, but I have some patches that will eventually use this.



--
This message was sent by Atlassian JIRA
(v6.1#6144)