[GitHub] [geode] jinmeiliao opened pull request #3285: GEODE-5971: refactor ExportLogsCommand and ExecuteScriptCommand to us…

["jinmeiliao (GitHub)" <gi...@apache.org>]

…e ResultModel

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3285 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao closed pull request #3285: GEODE-5971: refactor ExportLogsCommand and ExecuteScriptCommand to us…

["jinmeiliao (GitHub)" <gi...@apache.org>]

[ pull request closed by jinmeiliao ]

[ Full content available at: https://github.com/apache/geode/pull/3285 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on issue #3285: GEODE-5971: refactor ExportLogsCommand and ExecuteScriptCommand to us…

["jinmeiliao (GitHub)" <gi...@apache.org>]

@Petahhh 

[ Full content available at: https://github.com/apache/geode/pull/3285 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jdeppe-pivotal commented on pull request #3285: GEODE-5971: refactor ExportLogsCommand and ExecuteScriptCommand to us…

["jdeppe-pivotal (GitHub)" <gi...@apache.org>]

I'd prefer not to add extra methods just to facilitate testing. In general, I'm also not a fan of checking string content if at all possible. I think that:
```
assertThat(result.getInfoSection("info").getStringContent()).contains("foo");
```
Is equivalent to:
```
assertThat(result.getInfoSection("info").getContent()).containsOnly("foo");
```
and
```
assertThat(result.getInfoSection("info").getStringContent()).isEmpty();
```
is just:
```
assertThat(result.getInfoSection("info").getContent()).containsOnly("");
```


[ Full content available at: https://github.com/apache/geode/pull/3285 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org