You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2014/10/16 08:20:06 UTC
Review Request 26804: Knox custom commands are shown twice in the
service menu
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26804/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
Bugs: AMBARI-7805
https://issues.apache.org/jira/browse/AMBARI-7805
Repository: ambari
Description
-------
The custom commands for knox are stated explicity in the customaction map and needs to be excluded.
Also the service version for knox is incorrect in the knox metainfo.xml file
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/nagios_alerts.php 878f0dc
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/params.py e1100c4
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-servicegroups.cfg.j2 0aa4b68
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 1ed55d1
ambari-server/src/main/resources/stacks/HDP/2.2/role_command_order.json f8eb4c7
ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/configuration/kafka-broker.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/configuration/kafka-env.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/configuration/kafka-log4j.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/metainfo.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/kafka.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/kafka_broker.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/params.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/properties_config.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/service_check.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/status_params.py PRE-CREATION
ambari-server/src/test/python/stacks/2.2/KAFKA/test_kafka_broker.py PRE-CREATION
ambari-server/src/test/python/stacks/2.2/configs/default.json 5e984fe
ambari-web/app/data/HDP2/site_properties.js f6b1862
ambari-web/app/models/service_config.js 664ca62
ambari-web/app/models/stack_service.js 7f64212
Diff: https://reviews.apache.org/r/26804/diff/
Testing
-------
tested the patch e2e on live cluster
Thanks,
Jaimin Jetly
Re: Review Request 26804: Knox custom commands are shown twice in the
service menu
Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26804/#review56975
-----------------------------------------------------------
Ship it!
Ship It!
- Srimanth Gunturi
On Oct. 16, 2014, 6:22 a.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26804/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2014, 6:22 a.m.)
>
>
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
>
>
> Bugs: AMBARI-7805
> https://issues.apache.org/jira/browse/AMBARI-7805
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The custom commands for knox are stated explicity in the customaction map and needs to be excluded.
> Also the service version for knox is incorrect in the knox metainfo.xml file
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/metainfo.xml 571b73b
> ambari-web/app/assets/test/tests.js 8ab531c
> ambari-web/app/views/main/service/item.js 171f5ad
> ambari-web/test/app_test.js fb35c86
> ambari-web/test/views/main/service/item_test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26804/diff/
>
>
> Testing
> -------
>
> tested the patch e2e on live cluster
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 26804: Knox custom commands are shown twice in the
service menu
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26804/#review56898
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On Oct. 16, 2014, 6:22 a.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26804/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2014, 6:22 a.m.)
>
>
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
>
>
> Bugs: AMBARI-7805
> https://issues.apache.org/jira/browse/AMBARI-7805
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The custom commands for knox are stated explicity in the customaction map and needs to be excluded.
> Also the service version for knox is incorrect in the knox metainfo.xml file
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/metainfo.xml 571b73b
> ambari-web/app/assets/test/tests.js 8ab531c
> ambari-web/app/views/main/service/item.js 171f5ad
> ambari-web/test/app_test.js fb35c86
> ambari-web/test/views/main/service/item_test.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/26804/diff/
>
>
> Testing
> -------
>
> tested the patch e2e on live cluster
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 26804: Knox custom commands are shown twice in the
service menu
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26804/
-----------------------------------------------------------
(Updated Oct. 16, 2014, 6:22 a.m.)
Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
Changes
-------
Uploaded the wrong patch before.
Bugs: AMBARI-7805
https://issues.apache.org/jira/browse/AMBARI-7805
Repository: ambari
Description
-------
The custom commands for knox are stated explicity in the customaction map and needs to be excluded.
Also the service version for knox is incorrect in the knox metainfo.xml file
Diffs (updated)
-----
ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/metainfo.xml 571b73b
ambari-web/app/assets/test/tests.js 8ab531c
ambari-web/app/views/main/service/item.js 171f5ad
ambari-web/test/app_test.js fb35c86
ambari-web/test/views/main/service/item_test.js PRE-CREATION
Diff: https://reviews.apache.org/r/26804/diff/
Testing
-------
tested the patch e2e on live cluster
Thanks,
Jaimin Jetly