You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "angela (JIRA)" <ji...@apache.org> on 2013/09/10 11:20:52 UTC
[jira] [Commented] (OAK-1005) OpenAuthenticationConfiguration
should provide AuthInfo
[ https://issues.apache.org/jira/browse/OAK-1005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13762881#comment-13762881 ]
angela commented on OAK-1005:
-----------------------------
you can't and should not rely on ContentSession or Session returning a non-null user id!
since the OpenAuthenticationConfiguration doesn't perform any login and can't populate the
subject with principals it doesn't make too much sense to me to create an AuthInfo here.
> OpenAuthenticationConfiguration should provide AuthInfo
> -------------------------------------------------------
>
> Key: OAK-1005
> URL: https://issues.apache.org/jira/browse/OAK-1005
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
> Reporter: Bertrand Delacretaz
> Assignee: angela
> Priority: Minor
> Attachments: OAK-1005.patch
>
>
> While working on SLING-2788 I found that having OpenAuthenticationConfiguration provide minimal AuthInfo is helpful in some testing scenarios.
> I'll attach a suggested patch, I'm not very familiar with these security classes so feel free to tweak. My use case is making sure the ContentSession provides a userID, as currently some of my Sling tests fail due to the lack of that (and yes I'm going to setup proper authentication there at some point).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira