fsfs get revision root

[Chia-liang Kao <cl...@clkao.org>]

Hi,

I just found that the line:

    my $root = $fs->revision_root ($rev);

on a fsfs backend causes two open/read syscalls in raw:

   990 perl     CALL  open(0x80ea5e0,0,0x1b6)
   990 perl     NAMI  "/home/clkao/.svk/local/db/revs/2369"
   990 perl     RET   open 9
   990 perl     CALL  fstat(0x9,0xbfbfe2d0)
   990 perl     RET   fstat 0
   990 perl     CALL  lseek(0x9,0,0x8cdc,0,0)
   990 perl     RET   lseek 36060/0x8cdc
   990 perl     CALL  lseek(0x9,0,0x8c9c,0,0)
   990 perl     RET   lseek 35996/0x8c9c
   990 perl     CALL  read(0x9,0x80eb018,0x1000)
   990 perl     RET   read 64/0x40
   990 perl     CALL  lseek(0x9,0,0x83d0,0,0)
   990 perl     RET   lseek 33744/0x83d0
   990 perl     CALL  read(0x9,0x80eb018,0x1000)
   990 perl     RET   read 2316/0x90c
   990 perl     CALL  close(0x9)
   990 perl     RET   close 0

   990 perl     CALL  open(0x80ec300,0,0x1b6)
   990 perl     NAMI  "/home/clkao/.svk/local/db/revs/2369"
   990 perl     RET   open 9
   990 perl     CALL  lseek(0x9,0,0x83d0,0,0)
   990 perl     RET   lseek 33744/0x83d0
   990 perl     CALL  read(0x9,0x83bd018,0x1000)
   990 perl     RET   read 2316/0x90c
   990 perl     CALL  close(0x9)
   990 perl     RET   close 0

Note that the second open seeks and reads exactly the same content as
the last read in the previous open.  It would be good if we can avoid
the second open/read.

Cheers,
CLK



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org