You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/02/17 09:23:26 UTC
Review Request 31106: LENS-274 : Estimate api in drivers and REST api
in server
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31106/
-----------------------------------------------------------
Review request for lens, Himanshu Gahlaut, Jaideep dhok, Rajat Khandelwal, and Srikanth Sundarrajan.
Bugs: LENS-274
https://issues.apache.org/jira/browse/LENS-274
Repository: lens
Description
-------
Changes include :
- Adds REST api with ESTIMATE submit option for POST on queryapi/queries, which returns EstimateResult - which contains QueryCost, if successful, error otherwise.
- Adds estimate in HiveDriver which does explain for native table queries and nothing for OLAP queries
- Adds estimate in JDBCDriver which does explain for all queries
- Driver selection logic changed to call estimate instead of explain
- Added unit tests for drivers and server
Still todo :
Priority calculation logic still needs QueryPlan. Will fix this and update patch
Diffs
-----
lens-api/src/main/java/org/apache/lens/api/query/EstimateResult.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java ee64081
lens-api/src/main/java/org/apache/lens/api/query/SubmitOp.java 37e6f55
lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java 4f284a7
lens-cube/src/test/java/org/apache/lens/driver/cube/TestMinCostSelector.java 95aed16
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 6da1884
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 0b118de
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 5e8163e
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java 8ad8d03
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 0af38b1
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java c732e09
lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 9fc5b20
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 31ad625
lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 313d5a7
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 971c7db
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 02bf324
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java 433914a
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ca22b04
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 8d6037f
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 9b3ae68
Diff: https://reviews.apache.org/r/31106/diff/
Testing
-------
Tests passed in lens-driver-hive and lens-driver-jdbc. TestQueryService passes. Will update all test results.
Thanks,
Amareshwari Sriramadasu
Re: Review Request 31106: LENS-274 : Estimate api in drivers and REST
api in server
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Feb. 18, 2015, 10:24 a.m., Jaideep dhok wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, line 1762
> > <https://reviews.apache.org/r/31106/diff/2/?file=866235#file866235line1762>
> >
> > Why is this accepted with SubmitOp.EXPLAIN? should it be ESTIMATE?
Copy paste error. Thanks for catching
> On Feb. 18, 2015, 10:24 a.m., Jaideep dhok wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java, line 52
> > <https://reviews.apache.org/r/31106/diff/2/?file=866232#file866232line52>
> >
> > public access modifier not needed?
Not required for interface methods. Results in checkstyle error now.
> On Feb. 18, 2015, 10:24 a.m., Jaideep dhok wrote:
> > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java, line 558
> > <https://reviews.apache.org/r/31106/diff/2/?file=866225#file866225line558>
> >
> > Same, add query handle to error message
Explain and estimate are not associated with handle. Added user query in the log
> On Feb. 18, 2015, 10:24 a.m., Jaideep dhok wrote:
> > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, line 323
> > <https://reviews.apache.org/r/31106/diff/2/?file=866223#file866223line323>
> >
> > Instead of hardcoding 1 here and 0 in JDBC driver, should we declare two constants in QueryCost itself
> > INTERACTIVE_COST = 0
> > BATCH_COST = 1
Added Hive cost and JDBC cost as constants directly.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31106/#review72939
-----------------------------------------------------------
On Feb. 18, 2015, 11:57 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31106/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2015, 11:57 a.m.)
>
>
> Review request for lens, Himanshu Gahlaut, Jaideep dhok, Rajat Khandelwal, and Srikanth Sundarrajan.
>
>
> Bugs: LENS-274
> https://issues.apache.org/jira/browse/LENS-274
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes include :
>
> - Adds REST api with ESTIMATE submit option for POST on queryapi/queries, which returns EstimateResult - which contains QueryCost, if successful, error otherwise.
> - Adds estimate in HiveDriver which does explain for native table queries and nothing for OLAP queries
> - Adds estimate in JDBCDriver which does explain for all queries
> - Driver selection logic changed to call estimate instead of explain
> - Added unit tests for drivers and server
>
> Priority calculation logic still needs QueryPlan. Calling explain as part of execute in this patch.
> Created https://issues.apache.org/jira/browse/LENS-323 to use cube query context for priority.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/EstimateResult.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java ee64081
> lens-api/src/main/java/org/apache/lens/api/query/SubmitOp.java 37e6f55
> lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java 4f284a7
> lens-cube/src/test/java/org/apache/lens/driver/cube/TestMinCostSelector.java 95aed16
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 6da1884
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java e4b5fcc
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 0b118de
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 5e8163e
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java 8ad8d03
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 0af38b1
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java c732e09
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 9fc5b20
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 31ad625
> lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 313d5a7
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 971c7db
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 02bf324
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java 433914a
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ca22b04
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 8d6037f
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 9b3ae68
>
> Diff: https://reviews.apache.org/r/31106/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.799s]
> [INFO] Lens .............................................. SUCCESS [2.046s]
> [INFO] Lens API .......................................... SUCCESS [6.501s]
> [INFO] Lens API for server and extensions ................ SUCCESS [5.257s]
> [INFO] Lens Cube ......................................... SUCCESS [6:39.334s]
> [INFO] Lens DB storage ................................... SUCCESS [9.939s]
> [INFO] Lens Query Library ................................ SUCCESS [5.275s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:37.085s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [23.503s]
> [INFO] Lens Server ....................................... SUCCESS [4:30.442s]
> [INFO] Lens client ....................................... SUCCESS [24.899s]
> [INFO] Lens CLI .......................................... SUCCESS [1:58.019s]
> [INFO] Lens Examples ..................................... SUCCESS [0.857s]
> [INFO] Lens Distribution ................................. SUCCESS [10.422s]
> [INFO] Lens ML Lib ....................................... SUCCESS [43.884s]
> [INFO] Lens Regression ................................... SUCCESS [0.453s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:00.586s
> [INFO] Finished at: Tue Feb 17 09:32:35 UTC 2015
> [INFO] Final Memory: 97M/1218M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 31106: LENS-274 : Estimate api in drivers and REST
api in server
Posted by Jaideep dhok <ja...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31106/#review72939
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java
<https://reviews.apache.org/r/31106/#comment119059>
typo 'not'
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java
<https://reviews.apache.org/r/31106/#comment119060>
Add query handle to error message
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java
<https://reviews.apache.org/r/31106/#comment119063>
Instead of hardcoding 1 here and 0 in JDBC driver, should we declare two constants in QueryCost itself
INTERACTIVE_COST = 0
BATCH_COST = 1
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java
<https://reviews.apache.org/r/31106/#comment119061>
We are throwing LensException here, but NPE in estimate() we should throw the same in both places.
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java
<https://reviews.apache.org/r/31106/#comment119062>
Same, add query handle to error message
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java
<https://reviews.apache.org/r/31106/#comment119064>
should be OLAP Cube query.
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java
<https://reviews.apache.org/r/31106/#comment119065>
public access modifier not needed?
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
<https://reviews.apache.org/r/31106/#comment119066>
Why is this accepted with SubmitOp.EXPLAIN? should it be ESTIMATE?
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
<https://reviews.apache.org/r/31106/#comment119067>
query or session handle in log message
- Jaideep dhok
On Feb. 17, 2015, 9:34 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31106/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2015, 9:34 a.m.)
>
>
> Review request for lens, Himanshu Gahlaut, Jaideep dhok, Rajat Khandelwal, and Srikanth Sundarrajan.
>
>
> Bugs: LENS-274
> https://issues.apache.org/jira/browse/LENS-274
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes include :
>
> - Adds REST api with ESTIMATE submit option for POST on queryapi/queries, which returns EstimateResult - which contains QueryCost, if successful, error otherwise.
> - Adds estimate in HiveDriver which does explain for native table queries and nothing for OLAP queries
> - Adds estimate in JDBCDriver which does explain for all queries
> - Driver selection logic changed to call estimate instead of explain
> - Added unit tests for drivers and server
>
> Priority calculation logic still needs QueryPlan. Calling explain as part of execute in this patch.
> Created https://issues.apache.org/jira/browse/LENS-323 to use cube query context for priority.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/EstimateResult.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java ee64081
> lens-api/src/main/java/org/apache/lens/api/query/SubmitOp.java 37e6f55
> lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java 4f284a7
> lens-cube/src/test/java/org/apache/lens/driver/cube/TestMinCostSelector.java 95aed16
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 6da1884
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 0b118de
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 5e8163e
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java 8ad8d03
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 0af38b1
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java c732e09
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 9fc5b20
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 31ad625
> lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 313d5a7
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 971c7db
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 02bf324
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java 433914a
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ca22b04
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 8d6037f
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 9b3ae68
>
> Diff: https://reviews.apache.org/r/31106/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.799s]
> [INFO] Lens .............................................. SUCCESS [2.046s]
> [INFO] Lens API .......................................... SUCCESS [6.501s]
> [INFO] Lens API for server and extensions ................ SUCCESS [5.257s]
> [INFO] Lens Cube ......................................... SUCCESS [6:39.334s]
> [INFO] Lens DB storage ................................... SUCCESS [9.939s]
> [INFO] Lens Query Library ................................ SUCCESS [5.275s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:37.085s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [23.503s]
> [INFO] Lens Server ....................................... SUCCESS [4:30.442s]
> [INFO] Lens client ....................................... SUCCESS [24.899s]
> [INFO] Lens CLI .......................................... SUCCESS [1:58.019s]
> [INFO] Lens Examples ..................................... SUCCESS [0.857s]
> [INFO] Lens Distribution ................................. SUCCESS [10.422s]
> [INFO] Lens ML Lib ....................................... SUCCESS [43.884s]
> [INFO] Lens Regression ................................... SUCCESS [0.453s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:00.586s
> [INFO] Finished at: Tue Feb 17 09:32:35 UTC 2015
> [INFO] Final Memory: 97M/1218M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 31106: LENS-327 : Estimate api in drivers and REST
api in server
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31106/#review73113
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On Feb. 18, 2015, 6:36 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31106/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2015, 6:36 p.m.)
>
>
> Review request for lens, Himanshu Gahlaut, Jaideep dhok, Rajat Khandelwal, and Srikanth Sundarrajan.
>
>
> Bugs: LENS-327
> https://issues.apache.org/jira/browse/LENS-327
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes include :
>
> - Adds REST api with ESTIMATE submit option for POST on queryapi/queries, which returns EstimateResult - which contains QueryCost, if successful, error otherwise.
> - Adds estimate in HiveDriver which does explain for native table queries and nothing for OLAP queries
> - Adds estimate in JDBCDriver which does explain for all queries
> - Driver selection logic changed to call estimate instead of explain
> - Added unit tests for drivers and server
>
> Priority calculation logic still needs QueryPlan. Calling explain as part of execute in this patch.
> Created https://issues.apache.org/jira/browse/LENS-323 to use cube query context for priority.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/EstimateResult.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java ee64081
> lens-api/src/main/java/org/apache/lens/api/query/SubmitOp.java 37e6f55
> lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java 4f284a7
> lens-cube/src/test/java/org/apache/lens/driver/cube/TestMinCostSelector.java 95aed16
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 6da1884
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java e4b5fcc
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 0b118de
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 5e8163e
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java 8ad8d03
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 0af38b1
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java c732e09
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 9fc5b20
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 31ad625
> lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 313d5a7
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 971c7db
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 02bf324
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java 433914a
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ca22b04
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 8d6037f
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 9b3ae68
>
> Diff: https://reviews.apache.org/r/31106/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.799s]
> [INFO] Lens .............................................. SUCCESS [2.046s]
> [INFO] Lens API .......................................... SUCCESS [6.501s]
> [INFO] Lens API for server and extensions ................ SUCCESS [5.257s]
> [INFO] Lens Cube ......................................... SUCCESS [6:39.334s]
> [INFO] Lens DB storage ................................... SUCCESS [9.939s]
> [INFO] Lens Query Library ................................ SUCCESS [5.275s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:37.085s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [23.503s]
> [INFO] Lens Server ....................................... SUCCESS [4:30.442s]
> [INFO] Lens client ....................................... SUCCESS [24.899s]
> [INFO] Lens CLI .......................................... SUCCESS [1:58.019s]
> [INFO] Lens Examples ..................................... SUCCESS [0.857s]
> [INFO] Lens Distribution ................................. SUCCESS [10.422s]
> [INFO] Lens ML Lib ....................................... SUCCESS [43.884s]
> [INFO] Lens Regression ................................... SUCCESS [0.453s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:00.586s
> [INFO] Finished at: Tue Feb 17 09:32:35 UTC 2015
> [INFO] Final Memory: 97M/1218M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 31106: LENS-327 : Estimate api in drivers and REST
api in server
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31106/
-----------------------------------------------------------
(Updated Feb. 18, 2015, 1:06 p.m.)
Review request for lens, Himanshu Gahlaut, Jaideep dhok, Rajat Khandelwal, and Srikanth Sundarrajan.
Summary (updated)
-----------------
LENS-327 : Estimate api in drivers and REST api in server
Bugs: LENS-327
https://issues.apache.org/jira/browse/LENS-327
Repository: lens
Description
-------
Changes include :
- Adds REST api with ESTIMATE submit option for POST on queryapi/queries, which returns EstimateResult - which contains QueryCost, if successful, error otherwise.
- Adds estimate in HiveDriver which does explain for native table queries and nothing for OLAP queries
- Adds estimate in JDBCDriver which does explain for all queries
- Driver selection logic changed to call estimate instead of explain
- Added unit tests for drivers and server
Priority calculation logic still needs QueryPlan. Calling explain as part of execute in this patch.
Created https://issues.apache.org/jira/browse/LENS-323 to use cube query context for priority.
Diffs
-----
lens-api/src/main/java/org/apache/lens/api/query/EstimateResult.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java ee64081
lens-api/src/main/java/org/apache/lens/api/query/SubmitOp.java 37e6f55
lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java 4f284a7
lens-cube/src/test/java/org/apache/lens/driver/cube/TestMinCostSelector.java 95aed16
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 6da1884
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java e4b5fcc
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 0b118de
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 5e8163e
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java 8ad8d03
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 0af38b1
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java c732e09
lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 9fc5b20
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 31ad625
lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 313d5a7
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 971c7db
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 02bf324
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java 433914a
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ca22b04
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 8d6037f
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 9b3ae68
Diff: https://reviews.apache.org/r/31106/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.799s]
[INFO] Lens .............................................. SUCCESS [2.046s]
[INFO] Lens API .......................................... SUCCESS [6.501s]
[INFO] Lens API for server and extensions ................ SUCCESS [5.257s]
[INFO] Lens Cube ......................................... SUCCESS [6:39.334s]
[INFO] Lens DB storage ................................... SUCCESS [9.939s]
[INFO] Lens Query Library ................................ SUCCESS [5.275s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:37.085s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [23.503s]
[INFO] Lens Server ....................................... SUCCESS [4:30.442s]
[INFO] Lens client ....................................... SUCCESS [24.899s]
[INFO] Lens CLI .......................................... SUCCESS [1:58.019s]
[INFO] Lens Examples ..................................... SUCCESS [0.857s]
[INFO] Lens Distribution ................................. SUCCESS [10.422s]
[INFO] Lens ML Lib ....................................... SUCCESS [43.884s]
[INFO] Lens Regression ................................... SUCCESS [0.453s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:00.586s
[INFO] Finished at: Tue Feb 17 09:32:35 UTC 2015
[INFO] Final Memory: 97M/1218M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 31106: LENS-274 : Estimate api in drivers and REST
api in server
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31106/
-----------------------------------------------------------
(Updated Feb. 18, 2015, 11:57 a.m.)
Review request for lens, Himanshu Gahlaut, Jaideep dhok, Rajat Khandelwal, and Srikanth Sundarrajan.
Changes
-------
Review comments addressed
Bugs: LENS-274
https://issues.apache.org/jira/browse/LENS-274
Repository: lens
Description
-------
Changes include :
- Adds REST api with ESTIMATE submit option for POST on queryapi/queries, which returns EstimateResult - which contains QueryCost, if successful, error otherwise.
- Adds estimate in HiveDriver which does explain for native table queries and nothing for OLAP queries
- Adds estimate in JDBCDriver which does explain for all queries
- Driver selection logic changed to call estimate instead of explain
- Added unit tests for drivers and server
Priority calculation logic still needs QueryPlan. Calling explain as part of execute in this patch.
Created https://issues.apache.org/jira/browse/LENS-323 to use cube query context for priority.
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/query/EstimateResult.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java ee64081
lens-api/src/main/java/org/apache/lens/api/query/SubmitOp.java 37e6f55
lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java 4f284a7
lens-cube/src/test/java/org/apache/lens/driver/cube/TestMinCostSelector.java 95aed16
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 6da1884
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java e4b5fcc
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 0b118de
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 5e8163e
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java 8ad8d03
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 0af38b1
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java c732e09
lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 9fc5b20
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 31ad625
lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 313d5a7
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 971c7db
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 02bf324
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java 433914a
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ca22b04
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 8d6037f
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 9b3ae68
Diff: https://reviews.apache.org/r/31106/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.799s]
[INFO] Lens .............................................. SUCCESS [2.046s]
[INFO] Lens API .......................................... SUCCESS [6.501s]
[INFO] Lens API for server and extensions ................ SUCCESS [5.257s]
[INFO] Lens Cube ......................................... SUCCESS [6:39.334s]
[INFO] Lens DB storage ................................... SUCCESS [9.939s]
[INFO] Lens Query Library ................................ SUCCESS [5.275s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:37.085s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [23.503s]
[INFO] Lens Server ....................................... SUCCESS [4:30.442s]
[INFO] Lens client ....................................... SUCCESS [24.899s]
[INFO] Lens CLI .......................................... SUCCESS [1:58.019s]
[INFO] Lens Examples ..................................... SUCCESS [0.857s]
[INFO] Lens Distribution ................................. SUCCESS [10.422s]
[INFO] Lens ML Lib ....................................... SUCCESS [43.884s]
[INFO] Lens Regression ................................... SUCCESS [0.453s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:00.586s
[INFO] Finished at: Tue Feb 17 09:32:35 UTC 2015
[INFO] Final Memory: 97M/1218M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 31106: LENS-274 : Estimate api in drivers and REST
api in server
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On Feb. 17, 2015, 10:22 a.m., Rajat Khandelwal wrote:
> > lens-api/src/main/java/org/apache/lens/api/query/EstimateResult.java, line 78
> > <https://reviews.apache.org/r/31106/diff/2/?file=866218#file866218line78>
> >
> > Instead of keeping boolean `error`, we can compute `this.errorMsg == null || this.errorMsg.isEmpty()` in a separate getter-like method.
error field is useful in XML. When reading it JAXB object, user can simply check for boolean. When ErrorMsg is replaced with detailed error with a complex class, it becomes handy
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31106/#review72687
-----------------------------------------------------------
On Feb. 18, 2015, 11:57 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31106/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2015, 11:57 a.m.)
>
>
> Review request for lens, Himanshu Gahlaut, Jaideep dhok, Rajat Khandelwal, and Srikanth Sundarrajan.
>
>
> Bugs: LENS-274
> https://issues.apache.org/jira/browse/LENS-274
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes include :
>
> - Adds REST api with ESTIMATE submit option for POST on queryapi/queries, which returns EstimateResult - which contains QueryCost, if successful, error otherwise.
> - Adds estimate in HiveDriver which does explain for native table queries and nothing for OLAP queries
> - Adds estimate in JDBCDriver which does explain for all queries
> - Driver selection logic changed to call estimate instead of explain
> - Added unit tests for drivers and server
>
> Priority calculation logic still needs QueryPlan. Calling explain as part of execute in this patch.
> Created https://issues.apache.org/jira/browse/LENS-323 to use cube query context for priority.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/EstimateResult.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java ee64081
> lens-api/src/main/java/org/apache/lens/api/query/SubmitOp.java 37e6f55
> lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java 4f284a7
> lens-cube/src/test/java/org/apache/lens/driver/cube/TestMinCostSelector.java 95aed16
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 6da1884
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java e4b5fcc
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 0b118de
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 5e8163e
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java 8ad8d03
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 0af38b1
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java c732e09
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 9fc5b20
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 31ad625
> lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 313d5a7
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 971c7db
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 02bf324
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java 433914a
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ca22b04
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 8d6037f
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 9b3ae68
>
> Diff: https://reviews.apache.org/r/31106/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.799s]
> [INFO] Lens .............................................. SUCCESS [2.046s]
> [INFO] Lens API .......................................... SUCCESS [6.501s]
> [INFO] Lens API for server and extensions ................ SUCCESS [5.257s]
> [INFO] Lens Cube ......................................... SUCCESS [6:39.334s]
> [INFO] Lens DB storage ................................... SUCCESS [9.939s]
> [INFO] Lens Query Library ................................ SUCCESS [5.275s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:37.085s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [23.503s]
> [INFO] Lens Server ....................................... SUCCESS [4:30.442s]
> [INFO] Lens client ....................................... SUCCESS [24.899s]
> [INFO] Lens CLI .......................................... SUCCESS [1:58.019s]
> [INFO] Lens Examples ..................................... SUCCESS [0.857s]
> [INFO] Lens Distribution ................................. SUCCESS [10.422s]
> [INFO] Lens ML Lib ....................................... SUCCESS [43.884s]
> [INFO] Lens Regression ................................... SUCCESS [0.453s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:00.586s
> [INFO] Finished at: Tue Feb 17 09:32:35 UTC 2015
> [INFO] Final Memory: 97M/1218M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 31106: LENS-274 : Estimate api in drivers and REST
api in server
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31106/#review72687
-----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/query/EstimateResult.java
<https://reviews.apache.org/r/31106/#comment118755>
Instead of keeping boolean `error`, we can compute `this.errorMsg == null || this.errorMsg.isEmpty()` in a separate getter-like method.
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java
<https://reviews.apache.org/r/31106/#comment118756>
Assert the error message?
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java
<https://reviews.apache.org/r/31106/#comment118757>
HiveDriver has two separate test cases for existing table and non-existant table. JdbcDriver has single test combining the two. Please make this consistent.
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java
<https://reviews.apache.org/r/31106/#comment118758>
Change javadoc according to name change
- Rajat Khandelwal
On Feb. 17, 2015, 3:04 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31106/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2015, 3:04 p.m.)
>
>
> Review request for lens, Himanshu Gahlaut, Jaideep dhok, Rajat Khandelwal, and Srikanth Sundarrajan.
>
>
> Bugs: LENS-274
> https://issues.apache.org/jira/browse/LENS-274
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes include :
>
> - Adds REST api with ESTIMATE submit option for POST on queryapi/queries, which returns EstimateResult - which contains QueryCost, if successful, error otherwise.
> - Adds estimate in HiveDriver which does explain for native table queries and nothing for OLAP queries
> - Adds estimate in JDBCDriver which does explain for all queries
> - Driver selection logic changed to call estimate instead of explain
> - Added unit tests for drivers and server
>
> Priority calculation logic still needs QueryPlan. Calling explain as part of execute in this patch.
> Created https://issues.apache.org/jira/browse/LENS-323 to use cube query context for priority.
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/query/EstimateResult.java PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java ee64081
> lens-api/src/main/java/org/apache/lens/api/query/SubmitOp.java 37e6f55
> lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java 4f284a7
> lens-cube/src/test/java/org/apache/lens/driver/cube/TestMinCostSelector.java 95aed16
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 6da1884
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 0b118de
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 5e8163e
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java 8ad8d03
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 0af38b1
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java c732e09
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 9fc5b20
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 31ad625
> lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 313d5a7
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 971c7db
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 02bf324
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java 433914a
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ca22b04
> lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 8d6037f
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 9b3ae68
>
> Diff: https://reviews.apache.org/r/31106/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.799s]
> [INFO] Lens .............................................. SUCCESS [2.046s]
> [INFO] Lens API .......................................... SUCCESS [6.501s]
> [INFO] Lens API for server and extensions ................ SUCCESS [5.257s]
> [INFO] Lens Cube ......................................... SUCCESS [6:39.334s]
> [INFO] Lens DB storage ................................... SUCCESS [9.939s]
> [INFO] Lens Query Library ................................ SUCCESS [5.275s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:37.085s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [23.503s]
> [INFO] Lens Server ....................................... SUCCESS [4:30.442s]
> [INFO] Lens client ....................................... SUCCESS [24.899s]
> [INFO] Lens CLI .......................................... SUCCESS [1:58.019s]
> [INFO] Lens Examples ..................................... SUCCESS [0.857s]
> [INFO] Lens Distribution ................................. SUCCESS [10.422s]
> [INFO] Lens ML Lib ....................................... SUCCESS [43.884s]
> [INFO] Lens Regression ................................... SUCCESS [0.453s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:00.586s
> [INFO] Finished at: Tue Feb 17 09:32:35 UTC 2015
> [INFO] Final Memory: 97M/1218M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 31106: LENS-274 : Estimate api in drivers and REST
api in server
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31106/
-----------------------------------------------------------
(Updated Feb. 17, 2015, 9:34 a.m.)
Review request for lens, Himanshu Gahlaut, Jaideep dhok, Rajat Khandelwal, and Srikanth Sundarrajan.
Bugs: LENS-274
https://issues.apache.org/jira/browse/LENS-274
Repository: lens
Description (updated)
-------
Changes include :
- Adds REST api with ESTIMATE submit option for POST on queryapi/queries, which returns EstimateResult - which contains QueryCost, if successful, error otherwise.
- Adds estimate in HiveDriver which does explain for native table queries and nothing for OLAP queries
- Adds estimate in JDBCDriver which does explain for all queries
- Driver selection logic changed to call estimate instead of explain
- Added unit tests for drivers and server
Priority calculation logic still needs QueryPlan. Calling explain as part of execute in this patch.
Created https://issues.apache.org/jira/browse/LENS-323 to use cube query context for priority.
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/query/EstimateResult.java PRE-CREATION
lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java ee64081
lens-api/src/main/java/org/apache/lens/api/query/SubmitOp.java 37e6f55
lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java 4f284a7
lens-cube/src/test/java/org/apache/lens/driver/cube/TestMinCostSelector.java 95aed16
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 6da1884
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 0b118de
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 5e8163e
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java 8ad8d03
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 0af38b1
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java c732e09
lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java 9fc5b20
lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java 31ad625
lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 313d5a7
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java 971c7db
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 02bf324
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java 433914a
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ca22b04
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java 8d6037f
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 9b3ae68
Diff: https://reviews.apache.org/r/31106/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.799s]
[INFO] Lens .............................................. SUCCESS [2.046s]
[INFO] Lens API .......................................... SUCCESS [6.501s]
[INFO] Lens API for server and extensions ................ SUCCESS [5.257s]
[INFO] Lens Cube ......................................... SUCCESS [6:39.334s]
[INFO] Lens DB storage ................................... SUCCESS [9.939s]
[INFO] Lens Query Library ................................ SUCCESS [5.275s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:37.085s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [23.503s]
[INFO] Lens Server ....................................... SUCCESS [4:30.442s]
[INFO] Lens client ....................................... SUCCESS [24.899s]
[INFO] Lens CLI .......................................... SUCCESS [1:58.019s]
[INFO] Lens Examples ..................................... SUCCESS [0.857s]
[INFO] Lens Distribution ................................. SUCCESS [10.422s]
[INFO] Lens ML Lib ....................................... SUCCESS [43.884s]
[INFO] Lens Regression ................................... SUCCESS [0.453s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:00.586s
[INFO] Finished at: Tue Feb 17 09:32:35 UTC 2015
[INFO] Final Memory: 97M/1218M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu