You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@thrift.apache.org by "slachiewicz (via GitHub)" <gi...@apache.org> on 2026/09/07 17:21:46 UTC
[PR] Cap every build workflow job at 30 minutes [thrift]
slachiewicz opened a new pull request, #3816:
URL: https://github.com/apache/thrift/pull/3816
Only `lib-python` and `lib-python-macos` carried a `timeout-minutes`, so every other job in the build workflow runs to the 6-hour GitHub default when it hangs. `lib-d` hung in `make check` on 7 September and held a runner for 47 minutes.
The slowest job in a healthy run is `lib-netstd-codegen` at 8 minutes, so 30 leaves room for a slow runner while still failing a stuck one quickly. The two python jobs keep the 20 they already had.
Verified: parsing `build.yml` after the change lists all 18 jobs with a `timeout-minutes`.
*This change was created with AI assistance.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Cap every build workflow job at 60 minutes [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G merged PR #3816:
URL: https://github.com/apache/thrift/pull/3816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Cap every build workflow job at 60 minutes [thrift]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #3816:
URL: https://github.com/apache/thrift/pull/3816#issuecomment-5654583428
Thanks, that was the right check. I extended it to the 296 `build.yml` runs that concluded success or failure between 2026-08-25 and 2026-09-13: 16 successful jobs in 14 runs exceeded 30 minutes, all of them 28 to 42 minutes in an apt-get install step, none over 45.1. So 30 would have cost a re-run on about one run in twenty. Pushed 92a96757e with 60 instead, which clears every observed case and still cuts a hang from 360 minutes to 60. Per-job values do not buy anything, since the slow step is the same `libboost-all-dev` download in nearly every job; trimming that closure is a separate change worth measuring; cross-test runs prebuilt cpp binaries, so it likely needs only the boost runtime libraries.
*This comment was created with AI assistance.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Cap every build workflow job at 30 minutes [thrift]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #3816:
URL: https://github.com/apache/thrift/pull/3816#issuecomment-5634151279
### Code review
No blocking issues found. Checked for bugs and CLAUDE.md compliance.
One suggestion, below the bar for an issue but verified:
- 30 minutes also cuts off runs that currently pass. The table in the description covers the last five green master runs. Looking at `build.yml` runs from 2026-09-02 to 2026-09-11 instead, several jobs succeeded after more than 30 minutes because an apt-get step stalled on the package mirror:
- `cross-test (rb, java,kotlin)`: 34 min, 33 of them in "Install openssl and certificates" ([run 34139215123](https://github.com/apache/thrift/actions/runs/34139215123), push to master)
- `lib-java-kotlin`: 37 min, 33 of them in "Install dependencies" ([run 33613699571](https://github.com/apache/thrift/actions/runs/33613699571))
- `lib-erl (26.2, 3.27.0)`: 41 min, nearly all of it in "Install dependencies" ([run 34137352657](https://github.com/apache/thrift/actions/runs/34137352657))
With this change those runs fail and need a re-run. These numbers may help with the per-job values you asked about.
https://github.com/apache/thrift/blob/3074a90d44be96df7c9475e7ac4bd4cf80ca42cd/.github/workflows/build.yml#L1200-L1202
🤖 Generated with [Claude Code](https://claude.ai/code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Cap every build workflow job at 30 minutes [thrift]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #3816:
URL: https://github.com/apache/thrift/pull/3816#issuecomment-5599200313
30 minutes is still a lot and if You have suggestion what values apply to each module - i can adjust
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org