You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by hg...@apache.org on 2026/10/14 20:16:38 UTC
(iggy) branch perf/rust-pre-merge-coverage updated: fix(ci): stop partition env vars from failing config env tests
This is an automated email from the ASF dual-hosted git repository.
hubcio pushed a commit to branch perf/rust-pre-merge-coverage
in repository https://gitbox.apache.org/repos/asf/iggy.git
The following commit(s) were added to refs/heads/perf/rust-pre-merge-coverage by this push:
new e3aa4636a fix(ci): stop partition env vars from failing config env tests
e3aa4636a is described below
commit e3aa4636ab6dc5b49c47ed4c5e1c3a14a24107ff
Author: Hubert Gruszecki <h....@gmail.com>
AuthorDate: Wed Oct 14 22:14:06 2026 +0200
fix(ci): stop partition env vars from failing config env tests
The coverage test step exported TEST_PARTITION and TEST_PARTITIONS
through its env block, so every nextest process inherited them. The
config env tests scan the real environment with the TEST_ prefix,
and TypedEnvProvider panics in debug builds on unknown names, which
failed test shards 1/3 and 3/3.
Rename them to PARTITION_INDEX and PARTITION_COUNT, outside the
TEST_ prefix of those tests and the IGGY_ prefix that debug
servers check at boot.
---
.github/actions/rust/pre-merge/action.yml | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/.github/actions/rust/pre-merge/action.yml b/.github/actions/rust/pre-merge/action.yml
index 34d6c5d3c..0180b9bf7 100644
--- a/.github/actions/rust/pre-merge/action.yml
+++ b/.github/actions/rust/pre-merge/action.yml
@@ -312,13 +312,16 @@ runs:
- name: Run coverage test partition
if: inputs.task == 'test'
env:
- TEST_PARTITION: ${{ inputs.partition }}
- TEST_PARTITIONS: ${{ inputs.partitions }}
+ # Keep these out of TEST_* and IGGY_*. They reach every test process,
+ # where config env tests panic on unknown TEST_* names and debug
+ # servers refuse to boot on unknown IGGY_* names.
+ PARTITION_INDEX: ${{ inputs.partition }}
+ PARTITION_COUNT: ${{ inputs.partitions }}
run: |
set -euo pipefail
- if [[ ! "$TEST_PARTITION" =~ ^[1-9][0-9]*$ || ! "$TEST_PARTITIONS" =~ ^[1-9][0-9]*$ ]] ||
- (( TEST_PARTITION > TEST_PARTITIONS )); then
- echo "::error::Invalid test partition: $TEST_PARTITION/$TEST_PARTITIONS"
+ if [[ ! "$PARTITION_INDEX" =~ ^[1-9][0-9]*$ || ! "$PARTITION_COUNT" =~ ^[1-9][0-9]*$ ]] ||
+ (( PARTITION_INDEX > PARTITION_COUNT )); then
+ echo "::error::Invalid test partition: $PARTITION_INDEX/$PARTITION_COUNT"
exit 1
fi
ARTIFACT_DIR="$RUNNER_TEMP/rust-test-build"
@@ -385,7 +388,7 @@ runs:
cargo nextest run --archive-file "$ARTIFACT_DIR/nextest.tar.zst" \
--extract-to "$GITHUB_WORKSPACE" --extract-overwrite --workspace-remap "$GITHUB_WORKSPACE" \
--no-fail-fast --no-tests="$NO_TESTS" --profile ci \
- --partition "hash:${TEST_PARTITION}/${TEST_PARTITIONS}"
+ --partition "hash:${PARTITION_INDEX}/${PARTITION_COUNT}"
shell: bash
# On-disk format backwards compatibility. The script builds an iggy-server