You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/02/14 15:36:33 UTC
[GitHub] [ratis-thirdparty] adoroszlai opened a new pull request #28: RATIS-1515. Upgrade gRPC to 1.44.0, Netty to 4.1.74
adoroszlai opened a new pull request #28:
URL: https://github.com/apache/ratis-thirdparty/pull/28
## What changes were proposed in this pull request?
* Upgrade gRPC to latest 1.44.0.
* Upgrade Netty to latest 4.1.74. Netty tcnative version (2.0.48) now comes from Netty POM to ensure consistency.
https://issues.apache.org/jira/browse/RATIS-1515
## How was this patch tested?
CI:
https://github.com/adoroszlai/ratis-thirdparty/runs/5186299011#step:5:217
Built locally, verified that all native libraries are shaded:
```
$ unzip -t misc/target/ratis-thirdparty-misc-0.8.0-SNAPSHOT.jar | grep netty_
testing: META-INF/native/liborg_apache_ratis_thirdparty_netty_resolver_dns_native_macos_x86_64.jnilib OK
testing: META-INF/native/liborg_apache_ratis_thirdparty_netty_tcnative_linux_aarch_64.so OK
testing: META-INF/native/liborg_apache_ratis_thirdparty_netty_tcnative_linux_x86_64.so OK
testing: META-INF/native/liborg_apache_ratis_thirdparty_netty_tcnative_osx_aarch_64.jnilib OK
testing: META-INF/native/liborg_apache_ratis_thirdparty_netty_tcnative_osx_x86_64.jnilib OK
testing: META-INF/native/liborg_apache_ratis_thirdparty_netty_transport_native_epoll_aarch_64.so OK
testing: META-INF/native/liborg_apache_ratis_thirdparty_netty_transport_native_epoll_x86_64.so OK
testing: META-INF/native/liborg_apache_ratis_thirdparty_netty_transport_native_kqueue_x86_64.jnilib OK
testing: META-INF/native/org_apache_ratis_thirdparty_netty_tcnative_windows_x86_64.dll OK
```
Built Ratis with it and ran Ratis tests locally.
Also ran Thirdparty smoketests. Note that `GrpcSslTest` failed on MacOS x86 despite having the native libraries for that platform:
```
[main] ERROR demo.GrpcSslTest (GrpcSslTest.java:testSslClientServer(54)) - error starting server
java.lang.UnsatisfiedLinkError: failed to load the required native library
...
Caused by: java.lang.IllegalArgumentException: Failed to load any of the given libraries: [netty_tcnative_osx_x86_64, netty_tcnative_x86_64, netty_tcnative]
...
Suppressed: java.lang.UnsatisfiedLinkError: .../liborg_apache_ratis_thirdparty_netty_tcnative_osx_x86_644608907603584411798.dylib: dlopen(.../liborg_apache_ratis_thirdparty_netty_tcnative_osx_x86_644608907603584411798.dylib, 1): no suitable image found. Did find:
.../liborg_apache_ratis_thirdparty_netty_tcnative_osx_x86_644608907603584411798.dylib: cannot load 'liborg_apache_ratis_thirdparty_netty_tcnative_osx_x86_644608907603584411798.dylib' (load command 0x80000034 is unknown)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis-thirdparty] adoroszlai commented on pull request #28: RATIS-1515. Upgrade gRPC to 1.44.0, Netty to 4.1.74
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #28:
URL: https://github.com/apache/ratis-thirdparty/pull/28#issuecomment-1040142837
Thanks @szetszwo for reviewing and committing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis-thirdparty] adoroszlai commented on pull request #28: RATIS-1515. Upgrade gRPC to 1.44.0, Netty to 4.1.74
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #28:
URL: https://github.com/apache/ratis-thirdparty/pull/28#issuecomment-1040142837
Thanks @szetszwo for reviewing and committing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis-thirdparty] szetszwo merged pull request #28: RATIS-1515. Upgrade gRPC to 1.44.0, Netty to 4.1.74
Posted by GitBox <gi...@apache.org>.
szetszwo merged pull request #28:
URL: https://github.com/apache/ratis-thirdparty/pull/28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis-thirdparty] szetszwo merged pull request #28: RATIS-1515. Upgrade gRPC to 1.44.0, Netty to 4.1.74
Posted by GitBox <gi...@apache.org>.
szetszwo merged pull request #28:
URL: https://github.com/apache/ratis-thirdparty/pull/28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org