You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "btlqql (via GitHub)" <gi...@apache.org> on 2026/09/07 02:10:15 UTC
[I] Add regression coverage for agent engine store persistence and migration [rocketmq-dashboard]
btlqql opened a new issue, #4034:
URL: https://github.com/apache/rocketmq-dashboard/issues/4034
## Problem
The current test suite does not cover agent engine store persistence and migration.
## Expected behavior
- A focused Vitest case locks the existing behavior.
- The targeted test file passes and fails if the covered behavior regresses.
## Scope
Only add regression coverage for $(@{Slug=engine-store; Focus=agent engine store persistence and migration; PrTitle=test(ai-engine): cover agent engine persistence and migration; TestFile=web/src/stores/__tests__/engineStore.test.ts; Mode=new; Append=/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import { afterEach, describe, expect, it, vi } from 'vitest';
const STORAGE_KEY = 'rocketmq-studio-agent-engine';
async function loadStore(persistedEngine?: string, persistedVersion = 1) {
vi.resetModules();
if (persistedEngine !== undefined) {
localStorage.setItem(
STORAGE_KEY,
JSON.stringify({ state: { engine: persistedEngine }, version: persistedVersion }),
);
}
return (await import('../engineStore')).useEngineStore;
}
describe('engineStore', () => {
afterEach(() => {
vi.resetModules();
localStorage.clear();
});
it('defaults to claude-code when no preference is persisted', async () => {
const store = await loadStore();
expect(store.getState().engine).toBe('claude-code');
});
it('restores a persisted supported engine', async () => {
const store = await loadStore('qoder');
expect(store.getState().engine).toBe('qoder');
});
it('updates the persisted engine through the action', async () => {
const store = await loadStore('claude-code');
store.getState().setEngine('http');
expect(store.getState().engine).toBe('http');
});
it('migrates stale persisted engines back to claude-code', async () => {
const store = await loadStore('stale-engine', 0);
expect(store.getState().engine).toBe('claude-code');
});
});}.TestFile). No runtime behavior changes.
## Acceptance criteria
- [ ] The targeted Vitest file passes.
- [ ] git diff --check is clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add regression coverage for agent engine store persistence and migration [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on issue #4034:
URL: https://github.com/apache/rocketmq-dashboard/issues/4034#issuecomment-6093618542
Resolved by #5650 (merged into `rocketmq-studio` as 2f07500ba).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add regression coverage for agent engine store persistence and migration [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed issue #4034: Add regression coverage for agent engine store persistence and migration
URL: https://github.com/apache/rocketmq-dashboard/issues/4034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add regression coverage for agent engine store persistence and migration [rocketmq-dashboard]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #4034:
URL: https://github.com/apache/rocketmq-dashboard/issues/4034#issuecomment-5564480088
**Issue Evaluation**
Category: `enhancement` | Status: **Evaluated**
**Feasibility:** feasible
**Scope:** Test suite — frontend regression coverage
**Compatibility:** No breaking changes
This is a well-scoped test coverage improvement request. Adding focused Vitest regression cases for the specified behavior will help prevent future regressions and improve overall code quality.
**Assessment:** The issue clearly defines the expected behavior and target test file. This is a good candidate for community contribution.
---
*Automated evaluation by github-manager-bot*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org