apache-api/2258: The second arg to spawn_child_err() changed from "void (*)(void *)" in 1.2 to "int(*)(void *)" in 1.3

[Rob Saccoccio <ro...@InfiniteTechnology.com>]

>Number:         2258
>Category:       apache-api
>Synopsis:       The second arg to spawn_child_err() changed from "void (*)(void *)" in 1.2 to "int(*)(void *)" in 1.3
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    apache
>State:          open
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Wed May 20 08:00:01 PDT 1998
>Last-Modified:
>Originator:     robs@InfiniteTechnology.com
>Organization:
apache
>Release:        1.3
>Environment:
All
>Description:
The second arg to spawn_child_err() changed from "void (*)(void *)" (in 1.2)
to "int(*)(void *)" in (1.3).  This should be reflected in compat.h so as
to avoid unneccessary build warnings. 

Additionally, calls to spawn_child() should be changed to ap_spawn_child()
for consistency with the conversion to the new namespace.  This will
require ap_spawn_child() be defined in alloc.h instead of spawn_child()
(which should be only in compat.h).  The current approach is non-intuitive
and sets a bad example.
>How-To-Repeat:

>Fix:
In compat.h:

#define spawn_child_err ap_spawn_child_err

should become something like:

#define spawn_child_err(pool,func,data,kill,in,out,err) ap_spawn_child_err(pool,(int)func,data,kill,in,out,err)
>Audit-Trail:
>Unformatted:
[In order for any reply to be added to the PR database, ]
[you need to include <ap...@Apache.Org> in the Cc line ]
[and leave the subject line UNCHANGED.  This is not done]
[automatically because of the potential for mail loops. ]