[GitHub] [activemq-artemis] jbertram commented on a diff in pull request #4318: show description for mqtt-qos header

[GitBox <gi...@apache.org>]

jbertram commented on code in PR #4318:
URL: https://github.com/apache/activemq-artemis/pull/4318#discussion_r1051733194


##########
artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/components/browse.js:
##########
@@ -528,6 +528,8 @@ var Artemis;
 
         var routingTypes = ["multicast", "anycast"];
 
+        var mqttQosTypes = ["at most once", "at least once", "exactly once"];

Review Comment:
   I think the numeral should be retained here along with the description, e.g.:
   ```java
   var mqttQosTypes = ["0 - at most once", "1 - at least once", "2 - exactly once"];
   ```
   This is because lots of MQTT documentation, tutorials, and even the specification refer to QoS values directly by their numeral without any description so lots of folks more readily recognize the numeral. Also, lots of APIs use an integer for the QoS value so many developers will be accustomed to this representation as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org