You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by ravipesala <gi...@git.apache.org> on 2018/02/26 13:11:04 UTC
[GitHub] carbondata pull request #1999: [CARBONDATA-2204] Optimized number of reads o...
GitHub user ravipesala opened a pull request:
https://github.com/apache/carbondata/pull/1999
[CARBONDATA-2204] Optimized number of reads of tablestatus file while querying
As per the analysis of @xuchuanyin the number of reads of table status files while querying goes to 7 times for first query and 5 times for second query onwards.
This PR avoid reading status file multiple times. For first time query, it reads 2 times(Needed for datamap refresher) and 1 time for second query onwards.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ravipesala/incubator-carbondata tablestatus-read
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1999.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1999
----
commit 12ebff124664e3621f7cab95bea46a94bb4b036a
Author: ravipesala <ra...@...>
Date: 2018-02-26T13:06:03Z
Optimized number of reads of tablestatus file while querying
----
---
[GitHub] carbondata issue #1999: [CARBONDATA-2204] Optimized number of reads of table...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1999
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2690/
---
[GitHub] carbondata issue #1999: [CARBONDATA-2204] Optimized number of reads of table...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/1999
@ravipesala @jackylk
This has been verified: "For first time query, it reads 2 times and 1 time for second query onwards" :+1:
---
[GitHub] carbondata issue #1999: [CARBONDATA-2204] Optimized number of reads of table...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1999
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4054/
---
[GitHub] carbondata issue #1999: [CARBONDATA-2204] Optimized number of reads of table...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1999
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3683/
---
[GitHub] carbondata issue #1999: [CARBONDATA-2204] Optimized number of reads of table...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1999
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3906/
---
[GitHub] carbondata issue #1999: [CARBONDATA-2204] Optimized number of reads of table...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1999
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4020/
---
[GitHub] carbondata issue #1999: [CARBONDATA-2204] Optimized number of reads of table...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1999
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2661/
---
[GitHub] carbondata issue #1999: [CARBONDATA-2204] Optimized number of reads of table...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1999
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3934/
---
[GitHub] carbondata issue #1999: [CARBONDATA-2204] Optimized number of reads of table...
Posted by zzcclp <gi...@git.apache.org>.
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/1999
when can this pr be merged?
---
[GitHub] carbondata issue #1999: [CARBONDATA-2204] Optimized number of reads of table...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1999
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2660/
---
[GitHub] carbondata issue #1999: [CARBONDATA-2204] Optimized number of reads of table...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1999
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3905/
---
[GitHub] carbondata issue #1999: [CARBONDATA-2204] Optimized number of reads of table...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1999
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2808/
---
[GitHub] carbondata pull request #1999: [CARBONDATA-2204] Optimized number of reads o...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1999
---
[GitHub] carbondata pull request #1999: [CARBONDATA-2204] Optimized number of reads o...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1999#discussion_r171121669
--- Diff: core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java ---
@@ -164,6 +164,14 @@ public static String getMetadataPath(String tablePath) {
return tablePath + File.separator + METADATA_DIR;
}
+ /**
+ * Return table status file path based on `tablePath`
+ */
+ public static String getTableStatusFilePath(String tablePath) {
+ return getMetadataPath(tablePath) + CarbonCommonConstants.FILE_SEPARATOR
+ + CarbonCommonConstants.LOADMETADATA_FILENAME;
--- End diff --
Actually there is a variable called 'TABLE_STATUS_FILE' in Class 'CarbonTablePath' that represents string ’tablestatus‘, so there is no need to use an extra variable 'LOADMETADATA_FILENAME' in Class ’CarbonCommonConstants‘. Better to keep only one of them.
---
[GitHub] carbondata issue #1999: [CARBONDATA-2204] Optimized number of reads of table...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1999
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2776/
---
[GitHub] carbondata issue #1999: [CARBONDATA-2204] Optimized number of reads of table...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1999
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3684/
---
[GitHub] carbondata pull request #1999: [CARBONDATA-2204] Optimized number of reads o...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1999#discussion_r171772533
--- Diff: core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java ---
@@ -164,6 +164,14 @@ public static String getMetadataPath(String tablePath) {
return tablePath + File.separator + METADATA_DIR;
}
+ /**
+ * Return table status file path based on `tablePath`
+ */
+ public static String getTableStatusFilePath(String tablePath) {
+ return getMetadataPath(tablePath) + CarbonCommonConstants.FILE_SEPARATOR
+ + CarbonCommonConstants.LOADMETADATA_FILENAME;
--- End diff --
ok
---
[GitHub] carbondata issue #1999: [CARBONDATA-2204] Optimized number of reads of table...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1999
LGTM
---