You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jetspeed-dev@portals.apache.org by bu...@apache.org on 2003/08/06 18:38:39 UTC

DO NOT REPLY [Bug 22184] New: - FileServerPortlet not designed for subclassing

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22184>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=22184

FileServerPortlet not designed for subclassing

           Summary: FileServerPortlet not designed for subclassing
           Product: Jetspeed
           Version: 1.4b4
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Enhancement
          Priority: Other
         Component: Portlets
        AssignedTo: jetspeed-dev@jakarta.apache.org
        ReportedBy: monroe@dukece.com


The FileServerPortlet sets the content inside it's init() method.  Since it is 
good practice to for subclasses to always call super.init(), a subclass of 
FileServerPortlet will get its content set before it can do any processing.

In addition, the getURL(String) method is defined as private with makes it 
harder to overwrite.

Attached to this enhancement report is a diff file which does the following to 
make this class more extensible:

1) Move the setContent call to a separate protected method, initContent.
2) Make the getURL method protected.
3) Added some more javadoc comments.