You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by el...@apache.org on 2022/08/01 17:11:12 UTC

[airflow] branch main updated: Making sure serialization tests runs on all example dags (#25447)

This is an automated email from the ASF dual-hosted git repository.

eladkal pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git


The following commit(s) were added to refs/heads/main by this push:
     new a9a8df0749 Making sure serialization tests runs on all example dags (#25447)
a9a8df0749 is described below

commit a9a8df074972e39cdb7e03f38b668a8da94a7477
Author: eladkal <45...@users.noreply.github.com>
AuthorDate: Mon Aug 1 20:10:45 2022 +0300

    Making sure serialization tests runs on all example dags (#25447)
    
    while checking the failure of `TestStringifiedDAGs::test_serialization` in https://github.com/apache/airflow/runs/7608813338?check_suite_focus=true  (PR https://github.com/apache/airflow/pull/25280 )
    
    I noticed that we have:
    https://github.com/apache/airflow/blob/7d95bd9f416c9319f6b5c00058b0a1e3bd5bf805/tests/serialization/test_dag_serialization.py#L255-L256
    
    This test suppose to collect all example dags including providers but now in AIP-47 we move the example dags away from this path so the more we move the less coverage this test has.
    To solve this I added also the new paths
---
 tests/serialization/test_dag_serialization.py | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tests/serialization/test_dag_serialization.py b/tests/serialization/test_dag_serialization.py
index c6444b8aaa..7158851291 100644
--- a/tests/serialization/test_dag_serialization.py
+++ b/tests/serialization/test_dag_serialization.py
@@ -252,8 +252,10 @@ def collect_dags(dag_folder=None):
     else:
         patterns = [
             "airflow/example_dags",
-            "airflow/providers/*/example_dags",
-            "airflow/providers/*/*/example_dags",
+            "airflow/providers/*/example_dags",  # TODO: Remove once AIP-47 is completed
+            "airflow/providers/*/*/example_dags",  # TODO: Remove once AIP-47 is completed
+            "tests/system/providers/*/",
+            "tests/system/providers/*/*/",
         ]
     for pattern in patterns:
         for directory in glob(f"{ROOT_FOLDER}/{pattern}"):