You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/01/03 13:15:15 UTC
[GitHub] [apisix] spacewander opened a new pull request #5997: docs: list APISIX variable in a separate page
spacewander opened a new pull request #5997:
URL: https://github.com/apache/apisix/pull/5997
Fix #5990
Signed-off-by: spacewander <sp...@gmail.com>
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. If you need to resolve merge conflicts after the PR is reviewed, please merge master but do not rebase
6. Use "request review" to notify the reviewer once you have resolved the review
-->
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5997: docs: list APISIX variable in a separate page
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #5997:
URL: https://github.com/apache/apisix/pull/5997#discussion_r777790298
##########
File path: docs/en/latest/plugins/http-logger.md
##########
@@ -95,16 +95,6 @@ hello, world
Note that **the metadata configuration is applied in global scope**, which means it will take effect on all Route or Service which use http-logger plugin.
-**APISIX Variables**
-
-| Variable Name | Description | Usage Example |
-|------------------|-------------------------|----------------|
-| route_id | id of `route` | $route_id |
-| route_name | name of `route` | $route_name |
-| service_id | id of `service` | $service_id |
-| service_name | name of `service` | $service_name |
-| consumer_name | username of `consumer` | $consumer_name |
-
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bisakhmondal commented on a change in pull request #5997: docs: list APISIX variable in a separate page
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on a change in pull request #5997:
URL: https://github.com/apache/apisix/pull/5997#discussion_r777549600
##########
File path: docs/en/latest/plugins/http-logger.md
##########
@@ -95,16 +95,6 @@ hello, world
Note that **the metadata configuration is applied in global scope**, which means it will take effect on all Route or Service which use http-logger plugin.
-**APISIX Variables**
-
-| Variable Name | Description | Usage Example |
-|------------------|-------------------------|----------------|
-| route_id | id of `route` | $route_id |
-| route_name | name of `route` | $route_name |
-| service_id | id of `service` | $service_id |
-| service_name | name of `service` | $service_name |
-| consumer_name | username of `consumer` | $consumer_name |
-
Review comment:
As we are deleting the table, I think it would be better to add a hyperlink to the newly created `apisix-variable.md` inside the metadata schema `log_format` description [L94] (Also same to all the similar updates).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5997: docs: list APISIX variable in a separate page
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #5997:
URL: https://github.com/apache/apisix/pull/5997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bisakhmondal commented on a change in pull request #5997: docs: list APISIX variable in a separate page
Posted by GitBox <gi...@apache.org>.
bisakhmondal commented on a change in pull request #5997:
URL: https://github.com/apache/apisix/pull/5997#discussion_r777549600
##########
File path: docs/en/latest/plugins/http-logger.md
##########
@@ -95,16 +95,6 @@ hello, world
Note that **the metadata configuration is applied in global scope**, which means it will take effect on all Route or Service which use http-logger plugin.
-**APISIX Variables**
-
-| Variable Name | Description | Usage Example |
-|------------------|-------------------------|----------------|
-| route_id | id of `route` | $route_id |
-| route_name | name of `route` | $route_name |
-| service_id | id of `service` | $service_id |
-| service_name | name of `service` | $service_name |
-| consumer_name | username of `consumer` | $consumer_name |
-
Review comment:
nit: as we are deleting the table, I think it would be better to add a hyperlink to the newly created `apisix-variable.md` inside the metadata schema `log_format` description [L94] (Also same to all the similar updates).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org