You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by yh...@apache.org on 2015/07/28 00:49:46 UTC
spark git commit: [SPARK-9385] [PYSPARK] Enable PEP8 but disable
installing pylint.
Repository: spark
Updated Branches:
refs/heads/master ab6259566 -> dafe8d857
[SPARK-9385] [PYSPARK] Enable PEP8 but disable installing pylint.
Instead of disabling all python style check, we should enable PEP8. So, this PR just comments out the part installing pylint.
Author: Yin Huai <yh...@databricks.com>
Closes #7704 from yhuai/SPARK-9385 and squashes the following commits:
0056359 [Yin Huai] Enable PEP8 but disable installing pylint.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/dafe8d85
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/dafe8d85
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/dafe8d85
Branch: refs/heads/master
Commit: dafe8d857dff4c61981476282cbfe11f5c008078
Parents: ab62595
Author: Yin Huai <yh...@databricks.com>
Authored: Mon Jul 27 15:49:42 2015 -0700
Committer: Yin Huai <yh...@databricks.com>
Committed: Mon Jul 27 15:49:42 2015 -0700
----------------------------------------------------------------------
dev/lint-python | 30 +++++++++++++++---------------
dev/run-tests.py | 5 ++---
2 files changed, 17 insertions(+), 18 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/dafe8d85/dev/lint-python
----------------------------------------------------------------------
diff --git a/dev/lint-python b/dev/lint-python
index 53bccc1..575dbb0 100755
--- a/dev/lint-python
+++ b/dev/lint-python
@@ -58,21 +58,21 @@ export "PYTHONPATH=$SPARK_ROOT_DIR/dev/pylint"
export "PYLINT_HOME=$PYTHONPATH"
export "PATH=$PYTHONPATH:$PATH"
-if [ ! -d "$PYLINT_HOME" ]; then
- mkdir "$PYLINT_HOME"
- # Redirect the annoying pylint installation output.
- easy_install -d "$PYLINT_HOME" pylint==1.4.4 &>> "$PYLINT_INSTALL_INFO"
- easy_install_status="$?"
-
- if [ "$easy_install_status" -ne 0 ]; then
- echo "Unable to install pylint locally in \"$PYTHONPATH\"."
- cat "$PYLINT_INSTALL_INFO"
- exit "$easy_install_status"
- fi
-
- rm "$PYLINT_INSTALL_INFO"
-
-fi
+# if [ ! -d "$PYLINT_HOME" ]; then
+# mkdir "$PYLINT_HOME"
+# # Redirect the annoying pylint installation output.
+# easy_install -d "$PYLINT_HOME" pylint==1.4.4 &>> "$PYLINT_INSTALL_INFO"
+# easy_install_status="$?"
+#
+# if [ "$easy_install_status" -ne 0 ]; then
+# echo "Unable to install pylint locally in \"$PYTHONPATH\"."
+# cat "$PYLINT_INSTALL_INFO"
+# exit "$easy_install_status"
+# fi
+#
+# rm "$PYLINT_INSTALL_INFO"
+#
+# fi
# There is no need to write this output to a file
#+ first, but we do so so that the check status can
http://git-wip-us.apache.org/repos/asf/spark/blob/dafe8d85/dev/run-tests.py
----------------------------------------------------------------------
diff --git a/dev/run-tests.py b/dev/run-tests.py
index d1cb668..1f0d218 100755
--- a/dev/run-tests.py
+++ b/dev/run-tests.py
@@ -198,9 +198,8 @@ def run_scala_style_checks():
def run_python_style_checks():
- # set_title_and_block("Running Python style checks", "BLOCK_PYTHON_STYLE")
- # run_cmd([os.path.join(SPARK_HOME, "dev", "lint-python")])
- pass
+ set_title_and_block("Running Python style checks", "BLOCK_PYTHON_STYLE")
+ run_cmd([os.path.join(SPARK_HOME, "dev", "lint-python")])
def build_spark_documentation():
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org