You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/11/21 01:27:48 UTC

[GitHub] [zookeeper] pkuwm opened a new pull request #1545: ZOOKEEPER-4011: Fix build failure due to jUnit 5 usage in DIFFSyncConsistencyTest

pkuwm opened a new pull request #1545:
URL: https://github.com/apache/zookeeper/pull/1545


   ### Description
   Resolves [ZOOKEEPER-4011](https://issues.apache.org/jira/browse/ZOOKEEPER-4011)
   
   maven build fails on branch-3.6 because a commit that uses jUnit 5 was back ported to branch-3.6.
   
   ### Solution
   As discussed in https://github.com/apache/zookeeper/pull/1445, since cherry-picking jUnit 5 upgrades and there won't be too many back ports to 3.6 afterwards, we can just fix the issue by using jUnit 4 in the test.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] pkuwm closed pull request #1545: ZOOKEEPER-4011: Fix build failure due to jUnit 5 usage in DIFFSyncConsistencyTest

Posted by GitBox <gi...@apache.org>.
pkuwm closed pull request #1545:
URL: https://github.com/apache/zookeeper/pull/1545


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] hanm commented on pull request #1545: ZOOKEEPER-4011: Fix build failure due to jUnit 5 usage in DIFFSyncConsistencyTest

Posted by GitBox <gi...@apache.org>.
hanm commented on pull request #1545:
URL: https://github.com/apache/zookeeper/pull/1545#issuecomment-731694231


   merged as 96f65c8bb5217a514f24f52ebca5ca147b7d8337, please close this pull request. thanks @pkuwm !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zookeeper] pkuwm commented on pull request #1545: ZOOKEEPER-4011: Fix build failure due to jUnit 5 usage in DIFFSyncConsistencyTest

Posted by GitBox <gi...@apache.org>.
pkuwm commented on pull request #1545:
URL: https://github.com/apache/zookeeper/pull/1545#issuecomment-731484648


   @hanm @tamaashu Could you take a look? Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org