You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@clerezza.apache.org by mi...@apache.org on 2010/08/16 16:06:02 UTC
svn commit: r985938 -
/incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.tools.offline/src/main/java/org/apache/clerezza/tools/offline/Generator.java
Author: mir
Date: Mon Aug 16 14:06:02 2010
New Revision: 985938
URL: http://svn.apache.org/viewvc?rev=985938&view=rev
Log:
CLEREZZA-277: now closes its HTTPConnections
Modified:
incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.tools.offline/src/main/java/org/apache/clerezza/tools/offline/Generator.java
Modified: incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.tools.offline/src/main/java/org/apache/clerezza/tools/offline/Generator.java
URL: http://svn.apache.org/viewvc/incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.tools.offline/src/main/java/org/apache/clerezza/tools/offline/Generator.java?rev=985938&r1=985937&r2=985938&view=diff
==============================================================================
--- incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.tools.offline/src/main/java/org/apache/clerezza/tools/offline/Generator.java (original)
+++ incubator/clerezza/trunk/org.apache.clerezza.parent/org.apache.clerezza.tools.offline/src/main/java/org/apache/clerezza/tools/offline/Generator.java Mon Aug 16 14:06:02 2010
@@ -234,12 +234,16 @@ public class Generator {
}
final String responseContentType = urlConnection.getContentType();
if (!responseContentType.startsWith(mediaType.toString())) {
- throw new VariantUnavailableException("Got "+responseContentType+" and not "+mediaType);
+ throw new VariantUnavailableException("Got " + responseContentType + " and not " + mediaType);
}
- final InputStream in = urlConnection.getInputStream();
final ByteArrayOutputStream baos = new ByteArrayOutputStream();
- for (int ch = in.read(); ch != -1; ch = in.read()) {
- baos.write(ch);
+ final InputStream in = urlConnection.getInputStream();
+ try {
+ for (int ch = in.read(); ch != -1; ch = in.read()) {
+ baos.write(ch);
+ }
+ } finally {
+ in.close();
}
return baos.toByteArray();
}