You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2021/05/07 16:21:06 UTC

[GitHub] [libcloud] Kami commented on a change in pull request #1580: Add integration tests for S3 storage driver

Kami commented on a change in pull request #1580:
URL: https://github.com/apache/libcloud/pull/1580#discussion_r628349756



##########
File path: integration/storage/base.py
##########
@@ -284,6 +292,16 @@ def _create_tempfile(self, prefix='', content=b''):
             self.addCleanup(os.remove, path)
             return path
 
+        @classmethod
+        def _random_container_name(cls):
+            suffix = random_string(cls.container_name_max_length)
+            name = cls.container_name_prefix + suffix

Review comment:
       Yeah, I think including a special prefix on which we can filter on in the "clean up phase" is a good idea.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org