You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/02/08 15:35:22 UTC
[Impala-ASF-CR] IMPALA-5043: diagnostics for topic staleness in AC
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12407
Change subject: IMPALA-5043: diagnostics for topic staleness in AC
......................................................................
IMPALA-5043: diagnostics for topic staleness in AC
The default threshold for the admission control topic to be considered
stale is 5s.
Adds diagnostics for stale topic updates:
* A banner on the /admission web UI if the topic is considered stale.
* Time since last update on the /admission web UI
* Append a warning to rejection/queuing messages where topic staleness
may have affected the decision.
* Append a warning to profiles of admitted queries where the topic was
stale at the time the query was admitted.
* Include the topic staleness in all profiles of admitted queries
Testing:
Add a custom cluster test that kills the statestore, validates that
admission control behaves as expected and that stateless warnings
show up in the appropriate places.
Change-Id: Ib9e26adb6419589ccf7625e423356df45bee4ac9
---
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/admission-controller.h
M be/src/service/impala-http-handler.cc
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_admission_controller.py
M www/admission_controller.tmpl
6 files changed, 208 insertions(+), 34 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/12407/3
--
To view, visit http://gerrit.cloudera.org:8080/12407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9e26adb6419589ccf7625e423356df45bee4ac9
Gerrit-Change-Number: 12407
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-5043: diagnostics for topic staleness in AC
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12407 )
Change subject: IMPALA-5043: diagnostics for topic staleness in AC
......................................................................
Patch Set 3:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/12407/3/be/src/scheduling/admission-controller.cc
File be/src/scheduling/admission-controller.cc:
http://gerrit.cloudera.org:8080/#/c/12407/3/be/src/scheduling/admission-controller.cc@49
PS3, Line 49: stale
nit: repeated
http://gerrit.cloudera.org:8080/#/c/12407/3/be/src/scheduling/admission-controller.cc@292
PS3, Line 292: } else {
: last_topic_update_time_ms_ = MonotonicMillis();
this might be a bit misleading since this does not signify that the topic update was received. I think your intention was to keep the monotonicTime() - last_topic_update_time_ms_ be consistent, but how about we handle last_topic_update_time_ms_ == 0 as a separate case in GetStalenessDetailLocked() and mention that an update was never recieved
http://gerrit.cloudera.org:8080/#/c/12407/3/be/src/scheduling/admission-controller.cc@1127
PS3, Line 1127: // Include a space before the sentence because we're appending to an existing
: // sentence.
nit: 'stale' comment? :P
http://gerrit.cloudera.org:8080/#/c/12407/3/tests/custom_cluster/test_admission_controller.py
File tests/custom_cluster/test_admission_controller.py:
http://gerrit.cloudera.org:8080/#/c/12407/3/tests/custom_cluster/test_admission_controller.py@861
PS3, Line 861: STALE_TOPIC_THRESHOLD_MS
nit: maybe move this to the top with other constants? (feel free to ignore this comment)
http://gerrit.cloudera.org:8080/#/c/12407/3/tests/custom_cluster/test_admission_controller.py@919
PS3, Line 919: assert num_admitted_immediately == 1
: assert num_rejected == 1
: assert num_queued == NUM_QUERIES - 2
based on the AC config:
num_queued == 3
num_rejected == NUM_QUERIES - 4
because if NUM_QUERIES increases, the the queries rejected would increase.
--
To view, visit http://gerrit.cloudera.org:8080/12407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9e26adb6419589ccf7625e423356df45bee4ac9
Gerrit-Change-Number: 12407
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Feb 2019 19:49:35 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5043: diagnostics for topic staleness in AC
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12407 )
Change subject: IMPALA-5043: diagnostics for topic staleness in AC
......................................................................
Patch Set 4: Code-Review+2
(2 comments)
LGTM, i ll leave addressing my latest comment to your judgement
http://gerrit.cloudera.org:8080/#/c/12407/3/be/src/scheduling/admission-controller.cc
File be/src/scheduling/admission-controller.cc:
http://gerrit.cloudera.org:8080/#/c/12407/3/be/src/scheduling/admission-controller.cc@292
PS3, Line 292: }
: return status;
> Made that change. The update time reported is not quite right in that case
true, should we return a -1 in that case? (see other comment below)
http://gerrit.cloudera.org:8080/#/c/12407/4/be/src/scheduling/admission-controller.cc
File be/src/scheduling/admission-controller.cc:
http://gerrit.cloudera.org:8080/#/c/12407/4/be/src/scheduling/admission-controller.cc@1123
PS4, Line 1123: if (ms_since_last_update != nullptr) *ms_since_last_update = ms_since_update
should we return a value of -1 or something if last_topic_update_time_ms_ == 0 ??
--
To view, visit http://gerrit.cloudera.org:8080/12407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9e26adb6419589ccf7625e423356df45bee4ac9
Gerrit-Change-Number: 12407
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Feb 2019 23:59:54 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5043: diagnostics for topic staleness in AC
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12407 )
Change subject: IMPALA-5043: diagnostics for topic staleness in AC
......................................................................
IMPALA-5043: diagnostics for topic staleness in AC
The default threshold for the admission control topic to be considered
stale is 5s.
Adds diagnostics for stale topic updates:
* A banner on the /admission web UI if the topic is considered stale.
* Time since last update on the /admission web UI
* Append a warning to rejection/queuing messages where topic staleness
may have affected the decision.
* Append a warning to profiles of admitted queries where the topic was
stale at the time the query was admitted.
* Include the topic staleness in all profiles of admitted queries
Testing:
Add a custom cluster test that kills the statestore, validates that
admission control behaves as expected and that stateless warnings
show up in the appropriate places.
Change-Id: Ib9e26adb6419589ccf7625e423356df45bee4ac9
Reviewed-on: http://gerrit.cloudera.org:8080/12407
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/admission-controller.h
M be/src/service/impala-http-handler.cc
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_admission_controller.py
M www/admission_controller.tmpl
6 files changed, 208 insertions(+), 34 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9e26adb6419589ccf7625e423356df45bee4ac9
Gerrit-Change-Number: 12407
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-5043: diagnostics for topic staleness in AC
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12407 )
Change subject: IMPALA-5043: diagnostics for topic staleness in AC
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12407/4/be/src/scheduling/admission-controller.cc
File be/src/scheduling/admission-controller.cc:
http://gerrit.cloudera.org:8080/#/c/12407/4/be/src/scheduling/admission-controller.cc@1123
PS4, Line 1123: if (ms_since_last_update != nullptr) *ms_since_last_update = ms_since_update
> I figured it didn't really make a difference. I'm not sure how likely it's
wfm
--
To view, visit http://gerrit.cloudera.org:8080/12407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9e26adb6419589ccf7625e423356df45bee4ac9
Gerrit-Change-Number: 12407
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 09 Feb 2019 00:12:28 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5043: diagnostics for topic staleness in AC
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12407 )
Change subject: IMPALA-5043: diagnostics for topic staleness in AC
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9e26adb6419589ccf7625e423356df45bee4ac9
Gerrit-Change-Number: 12407
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 09 Feb 2019 01:15:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5043: diagnostics for topic staleness in AC
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12407 )
Change subject: IMPALA-5043: diagnostics for topic staleness in AC
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2047/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9e26adb6419589ccf7625e423356df45bee4ac9
Gerrit-Change-Number: 12407
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Feb 2019 22:43:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5043: diagnostics for topic staleness in AC
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Bikramjeet Vig, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12407
to look at the new patch set (#4).
Change subject: IMPALA-5043: diagnostics for topic staleness in AC
......................................................................
IMPALA-5043: diagnostics for topic staleness in AC
The default threshold for the admission control topic to be considered
stale is 5s.
Adds diagnostics for stale topic updates:
* A banner on the /admission web UI if the topic is considered stale.
* Time since last update on the /admission web UI
* Append a warning to rejection/queuing messages where topic staleness
may have affected the decision.
* Append a warning to profiles of admitted queries where the topic was
stale at the time the query was admitted.
* Include the topic staleness in all profiles of admitted queries
Testing:
Add a custom cluster test that kills the statestore, validates that
admission control behaves as expected and that stateless warnings
show up in the appropriate places.
Change-Id: Ib9e26adb6419589ccf7625e423356df45bee4ac9
---
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/admission-controller.h
M be/src/service/impala-http-handler.cc
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_admission_controller.py
M www/admission_controller.tmpl
6 files changed, 208 insertions(+), 34 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/12407/4
--
To view, visit http://gerrit.cloudera.org:8080/12407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib9e26adb6419589ccf7625e423356df45bee4ac9
Gerrit-Change-Number: 12407
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-5043: diagnostics for topic staleness in AC
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12407 )
Change subject: IMPALA-5043: diagnostics for topic staleness in AC
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3747/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9e26adb6419589ccf7625e423356df45bee4ac9
Gerrit-Change-Number: 12407
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 09 Feb 2019 01:15:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5043: diagnostics for topic staleness in AC
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12407 )
Change subject: IMPALA-5043: diagnostics for topic staleness in AC
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2041/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9e26adb6419589ccf7625e423356df45bee4ac9
Gerrit-Change-Number: 12407
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Feb 2019 16:19:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5043: diagnostics for topic staleness in AC
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12407 )
Change subject: IMPALA-5043: diagnostics for topic staleness in AC
......................................................................
Patch Set 3:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/12407/3/be/src/scheduling/admission-controller.cc
File be/src/scheduling/admission-controller.cc:
http://gerrit.cloudera.org:8080/#/c/12407/3/be/src/scheduling/admission-controller.cc@49
PS3, Line 49: stale
> nit: repeated
Done
http://gerrit.cloudera.org:8080/#/c/12407/3/be/src/scheduling/admission-controller.cc@292
PS3, Line 292: } else {
: last_topic_update_time_ms_ = MonotonicMillis();
> this might be a bit misleading since this does not signify that the topic u
Made that change. The update time reported is not quite right in that case but I think we can live with it (there's not really a more reasonable value to pick).
http://gerrit.cloudera.org:8080/#/c/12407/3/be/src/scheduling/admission-controller.cc@1127
PS3, Line 1127: // Include a space before the sentence because we're appending to an existing
: // sentence.
> nit: 'stale' comment? :P
Done
http://gerrit.cloudera.org:8080/#/c/12407/3/tests/custom_cluster/test_admission_controller.py
File tests/custom_cluster/test_admission_controller.py:
http://gerrit.cloudera.org:8080/#/c/12407/3/tests/custom_cluster/test_admission_controller.py@861
PS3, Line 861: STALE_TOPIC_THRESHOLD_MS
> nit: maybe move this to the top with other constants? (feel free to ignore
Done
http://gerrit.cloudera.org:8080/#/c/12407/3/tests/custom_cluster/test_admission_controller.py@919
PS3, Line 919: assert num_admitted_immediately == 1
: assert num_rejected == 1
: assert num_queued == NUM_QUERIES - 2
> based on the AC config:
Done
--
To view, visit http://gerrit.cloudera.org:8080/12407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9e26adb6419589ccf7625e423356df45bee4ac9
Gerrit-Change-Number: 12407
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Feb 2019 21:58:05 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5043: diagnostics for topic staleness in AC
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12407 )
Change subject: IMPALA-5043: diagnostics for topic staleness in AC
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12407/4/be/src/scheduling/admission-controller.cc
File be/src/scheduling/admission-controller.cc:
http://gerrit.cloudera.org:8080/#/c/12407/4/be/src/scheduling/admission-controller.cc@1123
PS4, Line 1123: if (ms_since_last_update != nullptr) *ms_since_last_update = ms_since_update
> should we return a value of -1 or something if last_topic_update_time_ms_ =
I figured it didn't really make a difference. I'm not sure how likely it's even to trigger this - Impala doesn't generally start up if it can't connect to the statestore.
--
To view, visit http://gerrit.cloudera.org:8080/12407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9e26adb6419589ccf7625e423356df45bee4ac9
Gerrit-Change-Number: 12407
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 09 Feb 2019 00:10:50 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5043: diagnostics for topic staleness in AC
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12407 )
Change subject: IMPALA-5043: diagnostics for topic staleness in AC
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12407
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9e26adb6419589ccf7625e423356df45bee4ac9
Gerrit-Change-Number: 12407
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 09 Feb 2019 05:16:42 +0000
Gerrit-HasComments: No