You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2020/03/19 02:10:44 UTC
Re: Review Request 72217: Added tests for master validation of limits
and shared cgroups.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72217/
-----------------------------------------------------------
(Updated March 19, 2020, 2:10 a.m.)
Review request for mesos, Andrei Budnik and Qian Zhang.
Summary (updated)
-----------------
Added tests for master validation of limits and shared cgroups.
Bugs: MESOS-10045
https://issues.apache.org/jira/browse/MESOS-10045
Repository: mesos
Description (updated)
-------
Added tests for master validation of limits and shared cgroups.
Diffs (updated)
-----
src/tests/master_validation_tests.cpp 8d5e74e82a2f9093b69120c1dbba33c56e25966b
Diff: https://reviews.apache.org/r/72217/diff/3/
Changes: https://reviews.apache.org/r/72217/diff/2-3/
Testing
-------
`make check`
Thanks,
Greg Mann
Re: Review Request 72217: Added tests for master validation of limits
and shared cgroups.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72217/#review220024
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/master_validation_tests.cpp
Lines 3672 (patched)
<https://reviews.apache.org/r/72217/#comment308287>
Why do we need to do this?
src/tests/master_validation_tests.cpp
Lines 3678-3683 (patched)
<https://reviews.apache.org/r/72217/#comment308286>
Why do we need this `executor` variable? I do not see it is used in the code below.
src/tests/master_validation_tests.cpp
Lines 4931-4934 (patched)
<https://reviews.apache.org/r/72217/#comment308288>
Why do we need this?
src/tests/master_validation_tests.cpp
Lines 5142-5145 (patched)
<https://reviews.apache.org/r/72217/#comment308289>
Ditto.
- Qian Zhang
On March 20, 2020, 9:07 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72217/
> -----------------------------------------------------------
>
> (Updated March 20, 2020, 9:07 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10045
> https://issues.apache.org/jira/browse/MESOS-10045
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for master validation of limits and shared cgroups.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp 8d5e74e82a2f9093b69120c1dbba33c56e25966b
>
>
> Diff: https://reviews.apache.org/r/72217/diff/4/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72217: Added tests for master validation of limits
and shared cgroups.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72217/
-----------------------------------------------------------
(Updated March 20, 2020, 5:34 p.m.)
Review request for mesos, Andrei Budnik and Qian Zhang.
Bugs: MESOS-10045
https://issues.apache.org/jira/browse/MESOS-10045
Repository: mesos
Description
-------
Added tests for master validation of limits and shared cgroups.
Diffs (updated)
-----
src/tests/master_validation_tests.cpp 8d5e74e82a2f9093b69120c1dbba33c56e25966b
Diff: https://reviews.apache.org/r/72217/diff/5/
Changes: https://reviews.apache.org/r/72217/diff/4-5/
Testing
-------
`make check`
Thanks,
Greg Mann
Re: Review Request 72217: Added tests for master validation of limits
and shared cgroups.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72217/
-----------------------------------------------------------
(Updated March 20, 2020, 1:07 a.m.)
Review request for mesos, Andrei Budnik and Qian Zhang.
Bugs: MESOS-10045
https://issues.apache.org/jira/browse/MESOS-10045
Repository: mesos
Description
-------
Added tests for master validation of limits and shared cgroups.
Diffs (updated)
-----
src/tests/master_validation_tests.cpp 8d5e74e82a2f9093b69120c1dbba33c56e25966b
Diff: https://reviews.apache.org/r/72217/diff/4/
Changes: https://reviews.apache.org/r/72217/diff/3-4/
Testing
-------
`make check`
Thanks,
Greg Mann