You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Till Rohrmann (JIRA)" <ji...@apache.org> on 2018/02/15 10:46:00 UTC

[jira] [Closed] (FLINK-8212) Pull EnvironmentInformation out of TaskManagerServices

     [ https://issues.apache.org/jira/browse/FLINK-8212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Till Rohrmann closed FLINK-8212.
--------------------------------
    Resolution: Fixed

Fixed via e3e601b39492291b5837e58741bf7da46c76404a

> Pull EnvironmentInformation out of TaskManagerServices
> ------------------------------------------------------
>
>                 Key: FLINK-8212
>                 URL: https://issues.apache.org/jira/browse/FLINK-8212
>             Project: Flink
>          Issue Type: Improvement
>          Components: Local Runtime, Network
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: mingleizhang
>            Priority: Major
>             Fix For: 1.5.0
>
>
> We should pull the {{EnvironmentInformation}} out of the {{TaskManagerServices}} where it is used to get access to the memory settings of the executing JVM. This unnecessarily couples the former with the latter and makes testing extremely hard (one has to use {{PowerMockRunner}} and mock the static {{EnvironmentInformation}}).
> When addressing this issue, then we should also refactor {{NetworkBufferCalculationTest}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)