You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/07/20 05:08:14 UTC
[GitHub] [skywalking-banyandb] hanahmily commented on a change in pull request #20: Index posting list
hanahmily commented on a change in pull request #20:
URL: https://github.com/apache/skywalking-banyandb/pull/20#discussion_r672809215
##########
File path: pkg/query/logical/plan_indexscan.go
##########
@@ -107,12 +108,13 @@ type indexScan struct {
}
func (i *indexScan) Execute(ec executor2.ExecutionContext) ([]data.Entity, error) {
- var chunkSet common.ChunkIDs
+ var chunkSet posting.List
for _, exprs := range i.conditionMap {
// TODO: Discuss which metadata should be used!
// 1) traceSeries Metadata: indirect mapping
// 2) indexRule Metadata: cannot uniquely determine traceSeries
- chunks, err := ec.Search(*i.traceMetadata, i.startTime, i.endTime, convertToConditions(exprs))
+ // TODO: should pass correct shardID
+ chunks, err := ec.Search(*i.traceMetadata, 0, i.startTime, i.endTime, convertToConditions(exprs))
Review comment:
@lujiajing1126 You should get shards info from the series module, then searching results among those shards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org