You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "ramkrishna.s.vasudevan (Created) (JIRA)" <ji...@apache.org> on 2012/04/17 17:34:20 UTC
[jira] [Created] (HBASE-5809) Avoid move api to take the
destination server same as the source server.
Avoid move api to take the destination server same as the source server.
------------------------------------------------------------------------
Key: HBASE-5809
URL: https://issues.apache.org/jira/browse/HBASE-5809
Project: HBase
Issue Type: Bug
Reporter: ramkrishna.s.vasudevan
Priority: Minor
In Move currently we take any destination specified and if the destination is same as the source we still do unassign and assign. Here we can have problems due to RegionAlreadyInTransitionException and thus hanging the region in RIT for long time. We can avoid this scenario by not allowing the move to happen in this scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5809) Avoid move api to take the
destination server same as the source server.
Posted by "rajeshbabu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
rajeshbabu updated HBASE-5809:
------------------------------
Attachment: HBASE-5809.patch
> Avoid move api to take the destination server same as the source server.
> ------------------------------------------------------------------------
>
> Key: HBASE-5809
> URL: https://issues.apache.org/jira/browse/HBASE-5809
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0
> Reporter: ramkrishna.s.vasudevan
> Priority: Minor
> Labels: patch
> Attachments: HBASE-5809.patch
>
>
> In Move currently we take any destination specified and if the destination is same as the source we still do unassign and assign. Here we can have problems due to RegionAlreadyInTransitionException and thus hanging the region in RIT for long time. We can avoid this scenario by not allowing the move to happen in this scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5809) Avoid move api to take the
destination server same as the source server.
Posted by "ramkrishna.s.vasudevan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257657#comment-13257657 ]
ramkrishna.s.vasudevan commented on HBASE-5809:
-----------------------------------------------
+1
> Avoid move api to take the destination server same as the source server.
> ------------------------------------------------------------------------
>
> Key: HBASE-5809
> URL: https://issues.apache.org/jira/browse/HBASE-5809
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0
> Reporter: ramkrishna.s.vasudevan
> Priority: Minor
> Labels: patch
> Attachments: HBASE-5809.patch
>
>
> In Move currently we take any destination specified and if the destination is same as the source we still do unassign and assign. Here we can have problems due to RegionAlreadyInTransitionException and thus hanging the region in RIT for long time. We can avoid this scenario by not allowing the move to happen in this scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5809) Avoid move api to take the
destination server same as the source server.
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257687#comment-13257687 ]
Hadoop QA commented on HBASE-5809:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12523374/HBASE-5809.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 6 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1578//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1578//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1578//console
This message is automatically generated.
> Avoid move api to take the destination server same as the source server.
> ------------------------------------------------------------------------
>
> Key: HBASE-5809
> URL: https://issues.apache.org/jira/browse/HBASE-5809
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1
> Reporter: ramkrishna.s.vasudevan
> Priority: Minor
> Labels: patch
> Fix For: 0.96.0, 0.94.1
>
> Attachments: HBASE-5809.patch
>
>
> In Move currently we take any destination specified and if the destination is same as the source we still do unassign and assign. Here we can have problems due to RegionAlreadyInTransitionException and thus hanging the region in RIT for long time. We can avoid this scenario by not allowing the move to happen in this scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5809) Avoid move api to take the
destination server same as the source server.
Posted by "ramkrishna.s.vasudevan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-5809:
------------------------------------------
Attachment: HBASE-5809.patch
This is what i finally committed. Small formatting change and corrected typo error.
> Avoid move api to take the destination server same as the source server.
> ------------------------------------------------------------------------
>
> Key: HBASE-5809
> URL: https://issues.apache.org/jira/browse/HBASE-5809
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Priority: Minor
> Labels: patch
> Fix For: 0.96.0
>
> Attachments: HBASE-5809.patch, HBASE-5809.patch
>
>
> In Move currently we take any destination specified and if the destination is same as the source we still do unassign and assign. Here we can have problems due to RegionAlreadyInTransitionException and thus hanging the region in RIT for long time. We can avoid this scenario by not allowing the move to happen in this scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5809) Avoid move api to take the
destination server same as the source server.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258805#comment-13258805 ]
Hudson commented on HBASE-5809:
-------------------------------
Integrated in HBase-TRUNK #2793 (See [https://builds.apache.org/job/HBase-TRUNK/2793/])
HBASE-5809 Avoid move api to take the destination server same as the source server. Addendum to correct tet case. (Ted) (Revision 1328594)
Result = FAILURE
ramkrishna :
Files :
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
> Avoid move api to take the destination server same as the source server.
> ------------------------------------------------------------------------
>
> Key: HBASE-5809
> URL: https://issues.apache.org/jira/browse/HBASE-5809
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Priority: Minor
> Labels: client
> Fix For: 0.96.0
>
> Attachments: 5809.addendum, HBASE-5809.patch, HBASE-5809.patch
>
>
> In Move currently we take any destination specified and if the destination is same as the source we still do unassign and assign. Here we can have problems due to RegionAlreadyInTransitionException and thus hanging the region in RIT for long time. We can avoid this scenario by not allowing the move to happen in this scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5809) Avoid move api to take the
destination server same as the source server.
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258464#comment-13258464 ]
Hudson commented on HBASE-5809:
-------------------------------
Integrated in HBase-TRUNK #2791 (See [https://builds.apache.org/job/HBase-TRUNK/2791/])
HBASE-5809 Avoid move api to take the destination server same as the source server. (Rajesh) (Revision 1328458)
Result = FAILURE
ramkrishna :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
> Avoid move api to take the destination server same as the source server.
> ------------------------------------------------------------------------
>
> Key: HBASE-5809
> URL: https://issues.apache.org/jira/browse/HBASE-5809
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Priority: Minor
> Labels: client
> Fix For: 0.96.0
>
> Attachments: HBASE-5809.patch, HBASE-5809.patch
>
>
> In Move currently we take any destination specified and if the destination is same as the source we still do unassign and assign. Here we can have problems due to RegionAlreadyInTransitionException and thus hanging the region in RIT for long time. We can avoid this scenario by not allowing the move to happen in this scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5809) Avoid move api to take the
destination server same as the source server.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258778#comment-13258778 ]
Hudson commented on HBASE-5809:
-------------------------------
Integrated in HBase-TRUNK-security #177 (See [https://builds.apache.org/job/HBase-TRUNK-security/177/])
HBASE-5809 Avoid move api to take the destination server same as the source server. (Rajesh) (Revision 1328458)
Result = FAILURE
ramkrishna :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
> Avoid move api to take the destination server same as the source server.
> ------------------------------------------------------------------------
>
> Key: HBASE-5809
> URL: https://issues.apache.org/jira/browse/HBASE-5809
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Priority: Minor
> Labels: client
> Fix For: 0.96.0
>
> Attachments: 5809.addendum, HBASE-5809.patch, HBASE-5809.patch
>
>
> In Move currently we take any destination specified and if the destination is same as the source we still do unassign and assign. Here we can have problems due to RegionAlreadyInTransitionException and thus hanging the region in RIT for long time. We can avoid this scenario by not allowing the move to happen in this scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5809) Avoid move api to take the
destination server same as the source server.
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257688#comment-13257688 ]
Uma Maheswara Rao G commented on HBASE-5809:
--------------------------------------------
small nit:
{code}
+ + " beacuse region already assigned to the same server " + dest + '.');
{code}
typo: beacuse -> because
> Avoid move api to take the destination server same as the source server.
> ------------------------------------------------------------------------
>
> Key: HBASE-5809
> URL: https://issues.apache.org/jira/browse/HBASE-5809
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1
> Reporter: ramkrishna.s.vasudevan
> Priority: Minor
> Labels: patch
> Fix For: 0.96.0, 0.94.1
>
> Attachments: HBASE-5809.patch
>
>
> In Move currently we take any destination specified and if the destination is same as the source we still do unassign and assign. Here we can have problems due to RegionAlreadyInTransitionException and thus hanging the region in RIT for long time. We can avoid this scenario by not allowing the move to happen in this scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5809) Avoid move api to take the
destination server same as the source server.
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258021#comment-13258021 ]
Uma Maheswara Rao G commented on HBASE-5809:
--------------------------------------------
Thanks Ram.
> Avoid move api to take the destination server same as the source server.
> ------------------------------------------------------------------------
>
> Key: HBASE-5809
> URL: https://issues.apache.org/jira/browse/HBASE-5809
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1
> Reporter: ramkrishna.s.vasudevan
> Priority: Minor
> Labels: patch
> Fix For: 0.96.0, 0.94.1
>
> Attachments: HBASE-5809.patch
>
>
> In Move currently we take any destination specified and if the destination is same as the source we still do unassign and assign. Here we can have problems due to RegionAlreadyInTransitionException and thus hanging the region in RIT for long time. We can avoid this scenario by not allowing the move to happen in this scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5809) Avoid move api to take the
destination server same as the source server.
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5809:
------------------------------
Attachment: 5809.addendum
The addendum fixes the incorrect comparison between server names.
> Avoid move api to take the destination server same as the source server.
> ------------------------------------------------------------------------
>
> Key: HBASE-5809
> URL: https://issues.apache.org/jira/browse/HBASE-5809
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Priority: Minor
> Labels: client
> Fix For: 0.96.0
>
> Attachments: 5809.addendum, HBASE-5809.patch, HBASE-5809.patch
>
>
> In Move currently we take any destination specified and if the destination is same as the source we still do unassign and assign. Here we can have problems due to RegionAlreadyInTransitionException and thus hanging the region in RIT for long time. We can avoid this scenario by not allowing the move to happen in this scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5809) Avoid move api to take the
destination server same as the source server.
Posted by "ramkrishna.s.vasudevan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-5809:
------------------------------------------
Affects Version/s: (was: 0.94.0)
0.92.1
Fix Version/s: 0.94.1
0.96.0
Will commit tomorrow unless no objection.
> Avoid move api to take the destination server same as the source server.
> ------------------------------------------------------------------------
>
> Key: HBASE-5809
> URL: https://issues.apache.org/jira/browse/HBASE-5809
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1
> Reporter: ramkrishna.s.vasudevan
> Priority: Minor
> Labels: patch
> Fix For: 0.96.0, 0.94.1
>
> Attachments: HBASE-5809.patch
>
>
> In Move currently we take any destination specified and if the destination is same as the source we still do unassign and assign. Here we can have problems due to RegionAlreadyInTransitionException and thus hanging the region in RIT for long time. We can avoid this scenario by not allowing the move to happen in this scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5809) Avoid move api to take the
destination server same as the source server.
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258792#comment-13258792 ]
ramkrishna.s.vasudevan commented on HBASE-5809:
-----------------------------------------------
+1 on addendum Ted. Thanks for the patch. I will commit it.
> Avoid move api to take the destination server same as the source server.
> ------------------------------------------------------------------------
>
> Key: HBASE-5809
> URL: https://issues.apache.org/jira/browse/HBASE-5809
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Priority: Minor
> Labels: client
> Fix For: 0.96.0
>
> Attachments: 5809.addendum, HBASE-5809.patch, HBASE-5809.patch
>
>
> In Move currently we take any destination specified and if the destination is same as the source we still do unassign and assign. Here we can have problems due to RegionAlreadyInTransitionException and thus hanging the region in RIT for long time. We can avoid this scenario by not allowing the move to happen in this scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5809) Avoid move api to take the
destination server same as the source server.
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258474#comment-13258474 ]
Zhihong Yu commented on HBASE-5809:
-----------------------------------
I looped the test using:
{code}
~/runtest.sh 4 TestMasterObserver#testRegionTransitionOperations
{code}
and got the following:
{code}
Failed tests: testRegionTransitionOperations(org.apache.hadoop.hbase.coprocessor.TestMasterObserver): Coprocessor should have been called on region move
...
TestMasterObserver#testRegionTransitionOperations failed, iteration: 2
{code}
> Avoid move api to take the destination server same as the source server.
> ------------------------------------------------------------------------
>
> Key: HBASE-5809
> URL: https://issues.apache.org/jira/browse/HBASE-5809
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Priority: Minor
> Labels: client
> Fix For: 0.96.0
>
> Attachments: HBASE-5809.patch, HBASE-5809.patch
>
>
> In Move currently we take any destination specified and if the destination is same as the source we still do unassign and assign. Here we can have problems due to RegionAlreadyInTransitionException and thus hanging the region in RIT for long time. We can avoid this scenario by not allowing the move to happen in this scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5809) Avoid move api to take the
destination server same as the source server.
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257677#comment-13257677 ]
Zhihong Yu commented on HBASE-5809:
-----------------------------------
You meant 'unless objection', I assume :-)
> Avoid move api to take the destination server same as the source server.
> ------------------------------------------------------------------------
>
> Key: HBASE-5809
> URL: https://issues.apache.org/jira/browse/HBASE-5809
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1
> Reporter: ramkrishna.s.vasudevan
> Priority: Minor
> Labels: patch
> Fix For: 0.96.0, 0.94.1
>
> Attachments: HBASE-5809.patch
>
>
> In Move currently we take any destination specified and if the destination is same as the source we still do unassign and assign. Here we can have problems due to RegionAlreadyInTransitionException and thus hanging the region in RIT for long time. We can avoid this scenario by not allowing the move to happen in this scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5809) Avoid move api to take the
destination server same as the source server.
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258793#comment-13258793 ]
ramkrishna.s.vasudevan commented on HBASE-5809:
-----------------------------------------------
Committed to trunk.
> Avoid move api to take the destination server same as the source server.
> ------------------------------------------------------------------------
>
> Key: HBASE-5809
> URL: https://issues.apache.org/jira/browse/HBASE-5809
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Priority: Minor
> Labels: client
> Fix For: 0.96.0
>
> Attachments: 5809.addendum, HBASE-5809.patch, HBASE-5809.patch
>
>
> In Move currently we take any destination specified and if the destination is same as the source we still do unassign and assign. Here we can have problems due to RegionAlreadyInTransitionException and thus hanging the region in RIT for long time. We can avoid this scenario by not allowing the move to happen in this scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5809) Avoid move api to take the
destination server same as the source server.
Posted by "ramkrishna.s.vasudevan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258015#comment-13258015 ]
ramkrishna.s.vasudevan commented on HBASE-5809:
-----------------------------------------------
@Uma
I will change this while commit. Thanks.
> Avoid move api to take the destination server same as the source server.
> ------------------------------------------------------------------------
>
> Key: HBASE-5809
> URL: https://issues.apache.org/jira/browse/HBASE-5809
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.92.1
> Reporter: ramkrishna.s.vasudevan
> Priority: Minor
> Labels: patch
> Fix For: 0.96.0, 0.94.1
>
> Attachments: HBASE-5809.patch
>
>
> In Move currently we take any destination specified and if the destination is same as the source we still do unassign and assign. Here we can have problems due to RegionAlreadyInTransitionException and thus hanging the region in RIT for long time. We can avoid this scenario by not allowing the move to happen in this scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5809) Avoid move api to take the
destination server same as the source server.
Posted by "rajeshbabu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
rajeshbabu updated HBASE-5809:
------------------------------
Labels: patch (was: )
Affects Version/s: 0.94.0
Status: Patch Available (was: Open)
Attached patch.Please review and provide your comments/suggestions.
> Avoid move api to take the destination server same as the source server.
> ------------------------------------------------------------------------
>
> Key: HBASE-5809
> URL: https://issues.apache.org/jira/browse/HBASE-5809
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0
> Reporter: ramkrishna.s.vasudevan
> Priority: Minor
> Labels: patch
>
> In Move currently we take any destination specified and if the destination is same as the source we still do unassign and assign. Here we can have problems due to RegionAlreadyInTransitionException and thus hanging the region in RIT for long time. We can avoid this scenario by not allowing the move to happen in this scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5809) Avoid move api to take the
destination server same as the source server.
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258483#comment-13258483 ]
Zhihong Yu commented on HBASE-5809:
-----------------------------------
I think the failure was due to testRegionTransitionOperations not checking whether the source and destination servers are the same:
{code}
master.move(firstGoodPair.getKey().getEncodedNameAsBytes(),
Bytes.toBytes(destName));
{code}
To make the test valid, destName should be chosen to be different from source server.
> Avoid move api to take the destination server same as the source server.
> ------------------------------------------------------------------------
>
> Key: HBASE-5809
> URL: https://issues.apache.org/jira/browse/HBASE-5809
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Priority: Minor
> Labels: client
> Fix For: 0.96.0
>
> Attachments: HBASE-5809.patch, HBASE-5809.patch
>
>
> In Move currently we take any destination specified and if the destination is same as the source we still do unassign and assign. Here we can have problems due to RegionAlreadyInTransitionException and thus hanging the region in RIT for long time. We can avoid this scenario by not allowing the move to happen in this scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-5809) Avoid move api to take the
destination server same as the source server.
Posted by "ramkrishna.s.vasudevan (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan reassigned HBASE-5809:
---------------------------------------------
Assignee: rajeshbabu
> Avoid move api to take the destination server same as the source server.
> ------------------------------------------------------------------------
>
> Key: HBASE-5809
> URL: https://issues.apache.org/jira/browse/HBASE-5809
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Priority: Minor
> Labels: patch
> Fix For: 0.96.0
>
> Attachments: HBASE-5809.patch
>
>
> In Move currently we take any destination specified and if the destination is same as the source we still do unassign and assign. Here we can have problems due to RegionAlreadyInTransitionException and thus hanging the region in RIT for long time. We can avoid this scenario by not allowing the move to happen in this scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-5809) Avoid move api to take the
destination server same as the source server.
Posted by "Zhihong Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu resolved HBASE-5809.
-------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
> Avoid move api to take the destination server same as the source server.
> ------------------------------------------------------------------------
>
> Key: HBASE-5809
> URL: https://issues.apache.org/jira/browse/HBASE-5809
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Priority: Minor
> Labels: client
> Fix For: 0.96.0
>
> Attachments: 5809.addendum, HBASE-5809.patch, HBASE-5809.patch
>
>
> In Move currently we take any destination specified and if the destination is same as the source we still do unassign and assign. Here we can have problems due to RegionAlreadyInTransitionException and thus hanging the region in RIT for long time. We can avoid this scenario by not allowing the move to happen in this scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5809) Avoid move api to take the
destination server same as the source server.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258860#comment-13258860 ]
Hudson commented on HBASE-5809:
-------------------------------
Integrated in HBase-TRUNK-security #178 (See [https://builds.apache.org/job/HBase-TRUNK-security/178/])
HBASE-5809 Avoid move api to take the destination server same as the source server. Addendum to correct tet case. (Ted) (Revision 1328594)
Result = FAILURE
ramkrishna :
Files :
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestMasterObserver.java
> Avoid move api to take the destination server same as the source server.
> ------------------------------------------------------------------------
>
> Key: HBASE-5809
> URL: https://issues.apache.org/jira/browse/HBASE-5809
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Priority: Minor
> Labels: client
> Fix For: 0.96.0
>
> Attachments: 5809.addendum, HBASE-5809.patch, HBASE-5809.patch
>
>
> In Move currently we take any destination specified and if the destination is same as the source we still do unassign and assign. Here we can have problems due to RegionAlreadyInTransitionException and thus hanging the region in RIT for long time. We can avoid this scenario by not allowing the move to happen in this scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5809) Avoid move api to take the
destination server same as the source server.
Posted by "ramkrishna.s.vasudevan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-5809:
------------------------------------------
Fix Version/s: (was: 0.94.1)
Issue Type: Improvement (was: Bug)
Committed to trunk. Made it as an improvement.
Thanks for the patch Rajesh.
Thanks for the review Ted and Uma.
> Avoid move api to take the destination server same as the source server.
> ------------------------------------------------------------------------
>
> Key: HBASE-5809
> URL: https://issues.apache.org/jira/browse/HBASE-5809
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.1
> Reporter: ramkrishna.s.vasudevan
> Priority: Minor
> Labels: patch
> Fix For: 0.96.0
>
> Attachments: HBASE-5809.patch
>
>
> In Move currently we take any destination specified and if the destination is same as the source we still do unassign and assign. Here we can have problems due to RegionAlreadyInTransitionException and thus hanging the region in RIT for long time. We can avoid this scenario by not allowing the move to happen in this scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5809) Avoid move api to take the
destination server same as the source server.
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258780#comment-13258780 ]
ramkrishna.s.vasudevan commented on HBASE-5809:
-----------------------------------------------
@Ted
Thanks for your follow up. But the same had passed in
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1578//testReport/.
The QA build that ran on this patch. I will check it up and commit the addendum.
> Avoid move api to take the destination server same as the source server.
> ------------------------------------------------------------------------
>
> Key: HBASE-5809
> URL: https://issues.apache.org/jira/browse/HBASE-5809
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Priority: Minor
> Labels: client
> Fix For: 0.96.0
>
> Attachments: 5809.addendum, HBASE-5809.patch, HBASE-5809.patch
>
>
> In Move currently we take any destination specified and if the destination is same as the source we still do unassign and assign. Here we can have problems due to RegionAlreadyInTransitionException and thus hanging the region in RIT for long time. We can avoid this scenario by not allowing the move to happen in this scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5809) Avoid move api to take the
destination server same as the source server.
Posted by "ramkrishna.s.vasudevan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ramkrishna.s.vasudevan updated HBASE-5809:
------------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Avoid move api to take the destination server same as the source server.
> ------------------------------------------------------------------------
>
> Key: HBASE-5809
> URL: https://issues.apache.org/jira/browse/HBASE-5809
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.1
> Reporter: ramkrishna.s.vasudevan
> Priority: Minor
> Labels: patch
> Fix For: 0.96.0
>
> Attachments: HBASE-5809.patch
>
>
> In Move currently we take any destination specified and if the destination is same as the source we still do unassign and assign. Here we can have problems due to RegionAlreadyInTransitionException and thus hanging the region in RIT for long time. We can avoid this scenario by not allowing the move to happen in this scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (HBASE-5809) Avoid move api to take the
destination server same as the source server.
Posted by "Zhihong Yu (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu reopened HBASE-5809:
-------------------------------
The test failure was visible on Hadoop QA as well:
https://builds.apache.org/job/PreCommit-HBASE-Build/1594//testReport/org.apache.hadoop.hbase.coprocessor/TestMasterObserver/testRegionTransitionOperations/
> Avoid move api to take the destination server same as the source server.
> ------------------------------------------------------------------------
>
> Key: HBASE-5809
> URL: https://issues.apache.org/jira/browse/HBASE-5809
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Priority: Minor
> Labels: client
> Fix For: 0.96.0
>
> Attachments: HBASE-5809.patch, HBASE-5809.patch
>
>
> In Move currently we take any destination specified and if the destination is same as the source we still do unassign and assign. Here we can have problems due to RegionAlreadyInTransitionException and thus hanging the region in RIT for long time. We can avoid this scenario by not allowing the move to happen in this scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5809) Avoid move api to take the
destination server same as the source server.
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5809:
------------------------------
Comment: was deleted
(was: I think the failure was due to testRegionTransitionOperations not checking whether the source and destination servers are the same:
{code}
master.move(firstGoodPair.getKey().getEncodedNameAsBytes(),
Bytes.toBytes(destName));
{code}
To make the test valid, destName should be chosen to be different from source server.)
> Avoid move api to take the destination server same as the source server.
> ------------------------------------------------------------------------
>
> Key: HBASE-5809
> URL: https://issues.apache.org/jira/browse/HBASE-5809
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.92.1
> Reporter: ramkrishna.s.vasudevan
> Assignee: rajeshbabu
> Priority: Minor
> Labels: client
> Fix For: 0.96.0
>
> Attachments: HBASE-5809.patch, HBASE-5809.patch
>
>
> In Move currently we take any destination specified and if the destination is same as the source we still do unassign and assign. Here we can have problems due to RegionAlreadyInTransitionException and thus hanging the region in RIT for long time. We can avoid this scenario by not allowing the move to happen in this scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5809) Avoid move api to take the
destination server same as the source server.
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257638#comment-13257638 ]
Zhihong Yu commented on HBASE-5809:
-----------------------------------
+1 on patch.
> Avoid move api to take the destination server same as the source server.
> ------------------------------------------------------------------------
>
> Key: HBASE-5809
> URL: https://issues.apache.org/jira/browse/HBASE-5809
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.0
> Reporter: ramkrishna.s.vasudevan
> Priority: Minor
> Labels: patch
> Attachments: HBASE-5809.patch
>
>
> In Move currently we take any destination specified and if the destination is same as the source we still do unassign and assign. Here we can have problems due to RegionAlreadyInTransitionException and thus hanging the region in RIT for long time. We can avoid this scenario by not allowing the move to happen in this scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira