[jira] [Resolved] (FINERACT-1014) From/To Amount Range and Period Validatation broken

["Awasum Yannick (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FINERACT-1014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Awasum Yannick resolved FINERACT-1014.
--------------------------------------
    Resolution: Fixed

> From/To Amount Range and Period Validatation broken
> ---------------------------------------------------
>
>                 Key: FINERACT-1014
>                 URL: https://issues.apache.org/jira/browse/FINERACT-1014
>             Project: Apache Fineract
>          Issue Type: Bug
>            Reporter: Michael Vorburger
>            Assignee: Percy Ashu
>            Priority: Major
>             Fix For: 1.4.0
>
>
> [~Percy Ashu]'s work for FINERACT-822 in [https://github.com/apache/fineract/pull/951/files] thanks to [https://errorprone.info/bugpattern/CompareToZero] has uncovered real bugs (not just "nice to have for hypothetical exotic JDKs, like that Error Prone doc makes it sound) in Fineract's From/To Amount Range and Period Validatation.. there were 4 places which did a Comparable compareTo() > 1 - which is obviously never the case; those validations were simply completely broken, and we're fixing them as part of enabling code quality checks with Error Prone.
> In theory, this code break clients who sent this wrong to the API, but that's a Good Thing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)