You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/25 07:56:11 UTC
[GitHub] [inlong] fuweng11 opened a new pull request, #5699: [INLONG-5698][Manager] Fixed the problem that the dataproxy cluster tag was restored to the default after the manager was restarted
fuweng11 opened a new pull request, #5699:
URL: https://github.com/apache/inlong/pull/5699
### Prepare a Pull Request
- Fixes #5698
### Motivation
Make sure the dataproxy cluster tag was not restored to the default after the manager was restarted.
### Modifications
After receiving the cluster heartbeat information, if there is a cluster with the same name, the information will not be modified.
### Verifying this change
- [X] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
### Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #5699: [INLONG-5698][Manager] Fixed the DataProxy cluster tag was restored after the manager was restarted
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #5699:
URL: https://github.com/apache/inlong/pull/5699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] woofyzhao commented on pull request #5699: [INLONG-5698][Manager] Fixed the DataProxy cluster tag was restored after the manager was restarted
Posted by GitBox <gi...@apache.org>.
woofyzhao commented on PR #5699:
URL: https://github.com/apache/inlong/pull/5699#issuecomment-1226973493
suggest searching for similar code snippets in case there are more like this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5699: [INLONG-5698][Manager] Fixed the DataProxy cluster tag was restored after the manager was restarted
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5699:
URL: https://github.com/apache/inlong/pull/5699#discussion_r954666592
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/heartbeat/HeartbeatManager.java:
##########
@@ -158,12 +157,11 @@ private ClusterInfo fetchCluster(ComponentHeartbeat componentHeartbeat) {
final String clusterName = componentHeartbeat.getClusterName();
final String type = componentHeartbeat.getComponentType();
final String clusterTag = componentHeartbeat.getClusterTag();
- List<InlongClusterEntity> entities = clusterMapper.selectByKey(clusterTag, clusterName, type);
- if (CollectionUtils.isNotEmpty(entities)) {
+ InlongClusterEntity entity = clusterMapper.selectByNameAndType(clusterName, type);
+ if (!Objects.isNull(entity)) {
Review Comment:
Just call `if (null != entity)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org