You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/07 14:10:39 UTC

[GitHub] [pulsar-client-go] bschofield commented on pull request #436: Add a bridge type to allow usage of zap logging by the pulsar client

bschofield commented on pull request #436:
URL: https://github.com/apache/pulsar-client-go/pull/436#issuecomment-756139059


   It does feel a little weird to include _zap_ as a dependency of this library, when the library doesn't use it directly. I wonder if another option might be to include an empty `go.mod` in the `log` package directory, so that _zap_ is not added to the top-level `go.mod` (https://github.com/golang/go/issues/30058#issuecomment-543815369). Users of _zap_ will already have it included in their own modules file.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org