You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/02/07 00:41:29 UTC
[GitHub] [skywalking-docker] hanahmily opened a new pull request #15: Reactoring the building procedure
hanahmily opened a new pull request #15:
URL: https://github.com/apache/skywalking-docker/pull/15
These changes intend to simplify the procedure of building and pushing images. The usage is shown in the relevant sections within `README.md`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] wu-sheng commented on a change in pull request #15: Reactoring the building procedure
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #15:
URL: https://github.com/apache/skywalking-docker/pull/15#discussion_r571514372
##########
File path: README.md
##########
@@ -17,5 +17,44 @@ The convenience images are published in docker hub.
- https://hub.docker.com/r/apache/skywalking-ui
- https://hub.docker.com/r/apache/skywalking-oap-server
+# How to build
+
+When the version < `8.4.0`, the release manifests are grouping by their major version number and full version number in `archive`.
+
+From `8.4.0`, issuing follows to build relevant docker images
+
+```sh
+# source 8/v8.4.0.sh if the target version is 8.4.0
+source <major_version>/v<version>.sh
+
+make
+```
+
+# How to publish images
+
+After a SkyWalking's Apache release, composing a new version environment setting script to `<major_version>` folder with the name like `v<version>.sh`
+
+Building images as below:
+
+```sh
+source <major_version>/v<version>.sh
+make
+```
+
+Verifying images:
+
+```sh
+# Booting up a compose of ES6, OAP server and UI
+make compose.es6
+# Booting up a compose of ES7, OAP server and UI
+make compose.es7
+```
+
+Pushing built images to docker hub repos:
+
+```sh
+make docker.push
+```
+
Review comment:
Could you add a section here talking about archive?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] wu-sheng merged pull request #15: Reactoring the building procedure
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #15:
URL: https://github.com/apache/skywalking-docker/pull/15
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-docker] hanahmily commented on a change in pull request #15: Reactoring the building procedure
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #15:
URL: https://github.com/apache/skywalking-docker/pull/15#discussion_r571548201
##########
File path: README.md
##########
@@ -17,5 +17,44 @@ The convenience images are published in docker hub.
- https://hub.docker.com/r/apache/skywalking-ui
- https://hub.docker.com/r/apache/skywalking-oap-server
+# How to build
+
+When the version < `8.4.0`, the release manifests are grouping by their major version number and full version number in `archive`.
+
+From `8.4.0`, issuing follows to build relevant docker images
+
+```sh
+# source 8/v8.4.0.sh if the target version is 8.4.0
+source <major_version>/v<version>.sh
+
+make
+```
+
+# How to publish images
+
+After a SkyWalking's Apache release, composing a new version environment setting script to `<major_version>` folder with the name like `v<version>.sh`
+
+Building images as below:
+
+```sh
+source <major_version>/v<version>.sh
+make
+```
+
+Verifying images:
+
+```sh
+# Booting up a compose of ES6, OAP server and UI
+make compose.es6
+# Booting up a compose of ES7, OAP server and UI
+make compose.es7
+```
+
+Pushing built images to docker hub repos:
+
+```sh
+make docker.push
+```
+
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org