You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/09/10 19:04:34 UTC
[GitHub] [lucene-solr] mayya-sharipova opened a new pull request #1856: LUCENE-9449 Skip docs with _doc sort and "after" (#1725)
mayya-sharipova opened a new pull request #1856:
URL: https://github.com/apache/lucene-solr/pull/1856
- Enhance DocComparator to provide an iterator over competitive
documents when searching with "after". This iterator can quickly position
on the desired "after" document skipping all documents and segments before
"after".
- Redesign numeric comparators to provide skipping functionality
by default.
Backport for #LUCENE-9449
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] jimczi commented on a change in pull request #1856: LUCENE-9449 Skip docs with _doc sort and "after" (#1725)
Posted by GitBox <gi...@apache.org>.
jimczi commented on a change in pull request #1856:
URL: https://github.com/apache/lucene-solr/pull/1856#discussion_r488434456
##########
File path: lucene/CHANGES.txt
##########
@@ -59,6 +65,12 @@ Optimizations
* LUCENE-9373: FunctionMatchQuery now accepts a "matchCost" optimization hint.
(Maxim Glazkov, David Smiley)
+* LUCENE-9449: Enhance DocComparator to provide an iterator over competitive
+ documents when searching with "after". This iterator can quickly position
+ on the desired "after" document skipping all documents and segments before
+ "after". Also redesign numeric comparators to provide skipping functionality
+ by default. (Mayya Sharipova, Jim Ferenczi)
Review comment:
The skipping functionality is not by default for numerics in this version ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1856: LUCENE-9449 Skip docs with _doc sort and "after" (#1725)
Posted by GitBox <gi...@apache.org>.
mayya-sharipova commented on a change in pull request #1856:
URL: https://github.com/apache/lucene-solr/pull/1856#discussion_r490355700
##########
File path: lucene/CHANGES.txt
##########
@@ -59,6 +65,12 @@ Optimizations
* LUCENE-9373: FunctionMatchQuery now accepts a "matchCost" optimization hint.
(Maxim Glazkov, David Smiley)
+* LUCENE-9449: Enhance DocComparator to provide an iterator over competitive
+ documents when searching with "after". This iterator can quickly position
+ on the desired "after" document skipping all documents and segments before
+ "after". Also redesign numeric comparators to provide skipping functionality
+ by default. (Mayya Sharipova, Jim Ferenczi)
Review comment:
Addressed in the last commit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mayya-sharipova commented on pull request #1856: LUCENE-9449 Skip docs with _doc sort and "after" (#1725)
Posted by GitBox <gi...@apache.org>.
mayya-sharipova commented on pull request #1856:
URL: https://github.com/apache/lucene-solr/pull/1856#issuecomment-690635209
@jimczi This is a backport for https://github.com/apache/lucene-solr/pull/1725. Not sure if you would like to review it, or I can just merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mayya-sharipova merged pull request #1856: LUCENE-9449 Skip docs with _doc sort and "after" (#1725)
Posted by GitBox <gi...@apache.org>.
mayya-sharipova merged pull request #1856:
URL: https://github.com/apache/lucene-solr/pull/1856
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org