You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/02 02:05:14 UTC
[GitHub] [apisix-ingress-controller] tao12345666333 opened a new issue #567: feat: implement apisix healthz check
tao12345666333 opened a new issue #567:
URL: https://github.com/apache/apisix-ingress-controller/issues/567
https://github.com/apache/apisix-ingress-controller/blob/70d010092b626c9c6959bd026e669dbb60153608/pkg/api/router/router.go#L28-L35
The current `/apisix/healthz` interface does not implement the check logic for Apache APISIX.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] sober-wang commented on issue #567: feat: implement apisix healthz check
Posted by GitBox <gi...@apache.org>.
sober-wang commented on issue #567:
URL: https://github.com/apache/apisix-ingress-controller/issues/567#issuecomment-912228549
>
>
> https://github.com/apache/apisix-ingress-controller/blob/70d010092b626c9c6959bd026e669dbb60153608/pkg/api/router/router.go#L28-L35
>
> The current `/apisix/healthz` interface does not implement the check logic for Apache APISIX.
This code is not check anything. Can I help you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #567: feat: implement apisix healthz check
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #567:
URL: https://github.com/apache/apisix-ingress-controller/issues/567#issuecomment-926244220
> This code is not check anything. Can I help you?
@sober-wang If you are interested in this, welcome to implement its logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 edited a comment on issue #567: feat: implement apisix healthz check
Posted by GitBox <gi...@apache.org>.
tao12345666333 edited a comment on issue #567:
URL: https://github.com/apache/apisix-ingress-controller/issues/567#issuecomment-872679605
Not at all, even in the current architecture, if we implement this interface, it will be beneficial.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #567: feat: implement apisix healthz check
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #567:
URL: https://github.com/apache/apisix-ingress-controller/issues/567#issuecomment-872763223
> Not at all, even in the current architecture, if we implement this interface, it will be beneficial.
OK, fail enough. BTW, it can be combined with the logic that the controller tries to campaign the leadership.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #567: feat: implement apisix healthz check
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #567:
URL: https://github.com/apache/apisix-ingress-controller/issues/567#issuecomment-872675319
@tao12345666333 Is this for the brand new arch in the future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #567: feat: implement apisix healthz check
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #567:
URL: https://github.com/apache/apisix-ingress-controller/issues/567#issuecomment-919146372
> 
>
>
>
> The access log for this request should be able to be closed. It's useless.
We can disable the logging middleware in the gin engine. PR is welcome to do this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] suninuni commented on issue #567: feat: implement apisix healthz check
Posted by GitBox <gi...@apache.org>.
suninuni commented on issue #567:
URL: https://github.com/apache/apisix-ingress-controller/issues/567#issuecomment-918895729
The access log for this request should be able to be closed. It's useless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 closed issue #567: feat: implement apisix healthz check
Posted by GitBox <gi...@apache.org>.
tao12345666333 closed issue #567:
URL: https://github.com/apache/apisix-ingress-controller/issues/567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #567: feat: implement apisix healthz check
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #567:
URL: https://github.com/apache/apisix-ingress-controller/issues/567#issuecomment-872679605
Not all, even in the current architecture, if we implement this interface, it will be beneficial.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #567: feat: implement apisix healthz check
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on issue #567:
URL: https://github.com/apache/apisix-ingress-controller/issues/567#issuecomment-872659105
/good-first-issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org