[GitHub] [flink] pnowojski commented on a change in pull request #7938: [FLINK-10941] Keep slots which contain unconsumed result partitions (on top of #7186)

[GitBox <gi...@apache.org>]

pnowojski commented on a change in pull request #7938: [FLINK-10941] Keep slots which contain unconsumed result partitions (on top of #7186)
URL: https://github.com/apache/flink/pull/7938#discussion_r273025830
 
 

 ##########
 File path: flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerTest.java
 ##########
 @@ -707,6 +709,49 @@ public void testTaskManagerTimeout() throws Exception {
 		}
 	}
 
+	/**
+	 * Tests that idle but not releasable task managers will not be released even if timed out.
+	 */
+	@Test
+	public void testTaskManagerTimeoutWhenNotReleasable() throws Exception {
 
 Review comment:
   Please do not introduce new mockito based tests - just use proper mocks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services