You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "sangyongchoi (via GitHub)" <gi...@apache.org> on 2023/09/22 09:54:09 UTC
[GitHub] [kafka] sangyongchoi opened a new pull request, #14423: remove meaningless lines
sangyongchoi opened a new pull request, #14423:
URL: https://github.com/apache/kafka/pull/14423
I found meaningless lines when look at the code.
So I send pr to remove.
thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] remove meaningless lines [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14423:
URL: https://github.com/apache/kafka/pull/14423#issuecomment-1874810052
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) <p> If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] remove meaningless lines [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #14423:
URL: https://github.com/apache/kafka/pull/14423#issuecomment-1977358577
hi @sangyongchoi welcome to Kafka community. I'm going to close this PR as this is too trivial to be merged. The Kafka docs is a good choice to find out the newbie issue since there are many stale content :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] remove meaningless lines [kafka]
Posted by "vamossagar12 (via GitHub)" <gi...@apache.org>.
vamossagar12 commented on PR #14423:
URL: https://github.com/apache/kafka/pull/14423#issuecomment-1746443694
Thanks for the PR @sangyongchoi. Couple of thoughts =>
1. If there are other instances of such lines which are meaningless, could you also add them.
2. Can you add `[MINOR]` in the PR title?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] remove meaningless lines [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 closed pull request #14423: [MINOR] remove meaningless lines
URL: https://github.com/apache/kafka/pull/14423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MINOR] remove meaningless lines [kafka]
Posted by "sangyongchoi (via GitHub)" <gi...@apache.org>.
sangyongchoi commented on PR #14423:
URL: https://github.com/apache/kafka/pull/14423#issuecomment-1747310104
@vamossagar12
1. If I find it while looking at the sauce, I will add it.
2. I do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org