[GitHub] [hudi] rmahindra123 commented on a change in pull request #3117: [HUDI-2028] Implement RockDbBasedMap as an alternate to DiskBasedMap in ExternalSpillableMap

[GitBox <gi...@apache.org>]

rmahindra123 commented on a change in pull request #3117:
URL: https://github.com/apache/hudi/pull/3117#discussion_r655683054



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/util/collection/RocksDBDAO.java
##########
@@ -351,6 +354,34 @@ public void delete(String columnFamilyName, String key) {
     return results.stream();
   }
 
+  /**
+   * Return Iterator of key-value pairs from RocksIterator.
+   *
+   * @param columnFamilyName Column Family Name
+   * @param <T>              Type of value stored
+   */
+  public <T extends Serializable> Iterator<T> iterator(String columnFamilyName) {

Review comment:
       @vinothchandar I am working on a lazy iterator to avoid unnecessary memory usage.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org