You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@samza.apache.org by Eli Reisman <in...@gmail.com> on 2015/07/27 01:29:25 UTC

Re: Review Request 35444: SAMZA-692: Scrooge (Scala) Thrift serde

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35444/
-----------------------------------------------------------

(Updated July 26, 2015, 11:29 p.m.)


Review request for samza.


Repository: samza


Description
-------

SAMZA-692: Scrooge (Scala) Thrift serde


Diffs (updated)
-----

  build.gradle 0852adc 
  gradle/dependency-versions-scala-2.10.gradle f12beaf 
  gradle/dependency-versions.gradle fb06e8e 
  samza-scrooge/src/main/resources/thrift/test.thrift PRE-CREATION 
  samza-scrooge/src/main/scala/org/apache/samza/scrooge/ThriftTest.scala PRE-CREATION 
  samza-scrooge/src/main/scala/org/apache/samza/scrooge/serde/SamzaScroogeDeserializer.scala PRE-CREATION 
  samza-scrooge/src/main/scala/org/apache/samza/scrooge/serde/ScroogeExampleSerdeFactory.scala PRE-CREATION 
  samza-scrooge/src/main/scala/org/apache/samza/scrooge/serde/ScroogeSerde.scala PRE-CREATION 
  samza-scrooge/src/main/scala/org/apache/samza/scrooge/util/ReflectUtil.scala PRE-CREATION 
  samza-scrooge/src/test/scala/org/apache/samza/scrooge/TestScroogeExampleSerde.scala PRE-CREATION 
  settings.gradle 19bff97 

Diff: https://reviews.apache.org/r/35444/diff/


Testing
-------

New unit test. Passes "./gradlew test" and "./gradlew check"


Thanks,

Eli Reisman