You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/10/12 03:43:27 UTC

[GitHub] [couchdb] jaydoane commented on a change in pull request #3782: Eliminate compiler warnings

jaydoane commented on a change in pull request #3782:
URL: https://github.com/apache/couchdb/pull/3782#discussion_r726736831



##########
File path: src/chttpd/src/chttpd_node.erl
##########
@@ -32,7 +32,7 @@ handle_node_req(#httpd{path_parts=[_, <<"_local">>]}=Req) ->
 handle_node_req(#httpd{path_parts=[A, <<"_local">>|Rest]}=Req) ->
     handle_node_req(Req#httpd{path_parts=[A, node()] ++ Rest});
 % GET /_node/$node/_versions
-handle_node_req(#httpd{method='GET', path_parts=[_, Node, <<"_versions">>]}=Req) ->
+handle_node_req(#httpd{method='GET', path_parts=[_, _, <<"_versions">>]}=Req) ->

Review comment:
       I originally used `_Node` but then the line was longer than I liked, so I just changed it to `_`. But you are right, it should be the former for consistency, so I've updated the commit to use `_Node` and changed the commit message appropriately.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org