[jira] [Commented] (PARQUET-870) ParquetFileWriter.appendFile does not close file handle - resource leak

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PARQUET-870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16994518#comment-16994518 ] 

ASF GitHub Bot commented on PARQUET-870:
----------------------------------------

Willymontaz commented on pull request #708: [PARQUET-870] Close ParquetFileWriter.appendFile file handle
URL: https://github.com/apache/parquet-mr/pull/708
 
 
   https://issues.apache.org/jira/browse/PARQUET-870
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> ParquetFileWriter.appendFile does not close file handle - resource leak
> -----------------------------------------------------------------------
>
>                 Key: PARQUET-870
>                 URL: https://issues.apache.org/jira/browse/PARQUET-870
>             Project: Parquet
>          Issue Type: Bug
>          Components: parquet-mr
>    Affects Versions: 1.8.0, 1.9.1
>            Reporter: George Smith
>            Priority: Major
>              Labels: pull-request-available
>
> Current implementation of the method ParquetFileWriter.appendFile does not close file handle.
> {code}ParquetFileReader.open(conf, file).appendTo(this);{code}
> My suggested fix is following:
> {code}
> try (ParquetFileReader reader = ParquetFileReader.open(conf, file)) {
>    reader.appendTo(this);
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)