You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shale.apache.org by cr...@apache.org on 2007/04/13 02:28:47 UTC

svn commit: r528293 - /shale/framework/trunk/shale-remoting/src/main/java/org/apache/shale/remoting/faces/RemotingPhaseListener.java

Author: craigmcc
Date: Thu Apr 12 17:28:46 2007
New Revision: 528293

URL: http://svn.apache.org/viewvc?view=rev&rev=528293
Log:
[SHALE-360] Previous commits to support a zero-relative index to pick which
FacesServlet mapping pattern to use fixed half of the underlying problem.  This
commit fixes the other half.  If some other phase listener has already
completed the response for this request, we should do nothing instead of
mistakenly trying to add our own resource output.

Thanks to Ken Paulsen for the patch.

Modified:
    shale/framework/trunk/shale-remoting/src/main/java/org/apache/shale/remoting/faces/RemotingPhaseListener.java

Modified: shale/framework/trunk/shale-remoting/src/main/java/org/apache/shale/remoting/faces/RemotingPhaseListener.java
URL: http://svn.apache.org/viewvc/shale/framework/trunk/shale-remoting/src/main/java/org/apache/shale/remoting/faces/RemotingPhaseListener.java?view=diff&rev=528293&r1=528292&r2=528293
==============================================================================
--- shale/framework/trunk/shale-remoting/src/main/java/org/apache/shale/remoting/faces/RemotingPhaseListener.java (original)
+++ shale/framework/trunk/shale-remoting/src/main/java/org/apache/shale/remoting/faces/RemotingPhaseListener.java Thu Apr 12 17:28:46 2007
@@ -98,6 +98,11 @@
             log().debug("Checking view identifier '" + context.getViewRoot().getViewId() + "'");
         }
 
+        // If someone else has already completed this request, we should not try
+        if (context.getResponseComplete()) {
+            return;
+        }
+
         // Match this view identifier against our configured patterns
         Iterator mappings = helper.getMappings(context).getMappings().iterator();
         while (mappings.hasNext()) {