You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "rmahindra123 (via GitHub)" <gi...@apache.org> on 2023/11/08 08:13:47 UTC
[PR] [HUDI-7052] Fix partition key validation for custom key generators. [hudi]
rmahindra123 opened a new pull request, #10014:
URL: https://github.com/apache/hudi/pull/10014
### Change Logs
Fix partition key validation for custom payloads. Currently, deltastreamer is failing for custom payloads, since custom key generators since custom keygenerators require :<type> in writer configs, but the suffix is removed when storing in table properties.
### Impact
_Describe any public API or user-facing feature change or any performance impact._
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7052] Fix partition key validation for custom key generators. [hudi]
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on PR #10014:
URL: https://github.com/apache/hudi/pull/10014#issuecomment-1819539341
can you check for CI failures. and rebase w/ latest master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7052] Fix partition key validation for custom key generators. [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10014:
URL: https://github.com/apache/hudi/pull/10014#issuecomment-1802226827
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "898d03c01442d0b4ac84056f25ff49f1f9aba0c0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20733",
"triggerID" : "898d03c01442d0b4ac84056f25ff49f1f9aba0c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 898d03c01442d0b4ac84056f25ff49f1f9aba0c0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20733)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7052] Fix partition key validation for custom key generators. [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10014:
URL: https://github.com/apache/hudi/pull/10014#issuecomment-1801306978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "898d03c01442d0b4ac84056f25ff49f1f9aba0c0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "898d03c01442d0b4ac84056f25ff49f1f9aba0c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 898d03c01442d0b4ac84056f25ff49f1f9aba0c0 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7052] Fix partition key validation for custom key generators. [hudi]
Posted by "rmahindra123 (via GitHub)" <gi...@apache.org>.
rmahindra123 commented on code in PR #10014:
URL: https://github.com/apache/hudi/pull/10014#discussion_r1401027162
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala:
##########
@@ -263,14 +263,14 @@ class HoodieSparkSqlWriterInternal {
}
}
+ val keyGenerator = HoodieSparkKeyGeneratorFactory.createKeyGenerator(new TypedProperties(hoodieConfig.getProps))
Review Comment:
Fixed the Auto Key Gen to do lazy init of configs. Lmk if that works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7052] Fix partition key validation for custom key generators. [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10014:
URL: https://github.com/apache/hudi/pull/10014#issuecomment-1822582183
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "898d03c01442d0b4ac84056f25ff49f1f9aba0c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20733",
"triggerID" : "898d03c01442d0b4ac84056f25ff49f1f9aba0c0",
"triggerType" : "PUSH"
}, {
"hash" : "c359d7d70cb6e34ce4d62b2f71f39b91b49ea334",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21070",
"triggerID" : "c359d7d70cb6e34ce4d62b2f71f39b91b49ea334",
"triggerType" : "PUSH"
}, {
"hash" : "32469364d39eebf69fb001955aa2cccdfc772f1c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21087",
"triggerID" : "32469364d39eebf69fb001955aa2cccdfc772f1c",
"triggerType" : "PUSH"
}, {
"hash" : "80725367a7e21160545ffa27ec1275a32e47e7c4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21092",
"triggerID" : "80725367a7e21160545ffa27ec1275a32e47e7c4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 80725367a7e21160545ffa27ec1275a32e47e7c4 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21092)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7052] Fix partition key validation for custom key generators. [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10014:
URL: https://github.com/apache/hudi/pull/10014#issuecomment-1823617478
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "898d03c01442d0b4ac84056f25ff49f1f9aba0c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20733",
"triggerID" : "898d03c01442d0b4ac84056f25ff49f1f9aba0c0",
"triggerType" : "PUSH"
}, {
"hash" : "c359d7d70cb6e34ce4d62b2f71f39b91b49ea334",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21070",
"triggerID" : "c359d7d70cb6e34ce4d62b2f71f39b91b49ea334",
"triggerType" : "PUSH"
}, {
"hash" : "32469364d39eebf69fb001955aa2cccdfc772f1c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21087",
"triggerID" : "32469364d39eebf69fb001955aa2cccdfc772f1c",
"triggerType" : "PUSH"
}, {
"hash" : "80725367a7e21160545ffa27ec1275a32e47e7c4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21092",
"triggerID" : "80725367a7e21160545ffa27ec1275a32e47e7c4",
"triggerType" : "PUSH"
}, {
"hash" : "5e60b3d12b40a04006d3697fa99538e9e494b96c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21108",
"triggerID" : "5e60b3d12b40a04006d3697fa99538e9e494b96c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5e60b3d12b40a04006d3697fa99538e9e494b96c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21108)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7052] Fix partition key validation for custom key generators. [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10014:
URL: https://github.com/apache/hudi/pull/10014#issuecomment-1822385656
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "898d03c01442d0b4ac84056f25ff49f1f9aba0c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20733",
"triggerID" : "898d03c01442d0b4ac84056f25ff49f1f9aba0c0",
"triggerType" : "PUSH"
}, {
"hash" : "c359d7d70cb6e34ce4d62b2f71f39b91b49ea334",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21070",
"triggerID" : "c359d7d70cb6e34ce4d62b2f71f39b91b49ea334",
"triggerType" : "PUSH"
}, {
"hash" : "32469364d39eebf69fb001955aa2cccdfc772f1c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21087",
"triggerID" : "32469364d39eebf69fb001955aa2cccdfc772f1c",
"triggerType" : "PUSH"
}, {
"hash" : "80725367a7e21160545ffa27ec1275a32e47e7c4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "80725367a7e21160545ffa27ec1275a32e47e7c4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c359d7d70cb6e34ce4d62b2f71f39b91b49ea334 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21070)
* 32469364d39eebf69fb001955aa2cccdfc772f1c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21087)
* 80725367a7e21160545ffa27ec1275a32e47e7c4 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7052] Fix partition key validation for custom key generators. [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10014:
URL: https://github.com/apache/hudi/pull/10014#issuecomment-1823391577
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "898d03c01442d0b4ac84056f25ff49f1f9aba0c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20733",
"triggerID" : "898d03c01442d0b4ac84056f25ff49f1f9aba0c0",
"triggerType" : "PUSH"
}, {
"hash" : "c359d7d70cb6e34ce4d62b2f71f39b91b49ea334",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21070",
"triggerID" : "c359d7d70cb6e34ce4d62b2f71f39b91b49ea334",
"triggerType" : "PUSH"
}, {
"hash" : "32469364d39eebf69fb001955aa2cccdfc772f1c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21087",
"triggerID" : "32469364d39eebf69fb001955aa2cccdfc772f1c",
"triggerType" : "PUSH"
}, {
"hash" : "80725367a7e21160545ffa27ec1275a32e47e7c4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21092",
"triggerID" : "80725367a7e21160545ffa27ec1275a32e47e7c4",
"triggerType" : "PUSH"
}, {
"hash" : "5e60b3d12b40a04006d3697fa99538e9e494b96c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5e60b3d12b40a04006d3697fa99538e9e494b96c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 80725367a7e21160545ffa27ec1275a32e47e7c4 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21092)
* 5e60b3d12b40a04006d3697fa99538e9e494b96c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7052] Fix partition key validation for custom key generators. [hudi]
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan merged PR #10014:
URL: https://github.com/apache/hudi/pull/10014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7052] Fix partition key validation for custom key generators. [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10014:
URL: https://github.com/apache/hudi/pull/10014#issuecomment-1821543331
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "898d03c01442d0b4ac84056f25ff49f1f9aba0c0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20733",
"triggerID" : "898d03c01442d0b4ac84056f25ff49f1f9aba0c0",
"triggerType" : "PUSH"
}, {
"hash" : "c359d7d70cb6e34ce4d62b2f71f39b91b49ea334",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c359d7d70cb6e34ce4d62b2f71f39b91b49ea334",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 898d03c01442d0b4ac84056f25ff49f1f9aba0c0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20733)
* c359d7d70cb6e34ce4d62b2f71f39b91b49ea334 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7052] Fix partition key validation for custom key generators. [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10014:
URL: https://github.com/apache/hudi/pull/10014#issuecomment-1801318651
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "898d03c01442d0b4ac84056f25ff49f1f9aba0c0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20733",
"triggerID" : "898d03c01442d0b4ac84056f25ff49f1f9aba0c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 898d03c01442d0b4ac84056f25ff49f1f9aba0c0 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20733)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7052] Fix partition key validation for custom key generators. [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10014:
URL: https://github.com/apache/hudi/pull/10014#issuecomment-1823446823
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "898d03c01442d0b4ac84056f25ff49f1f9aba0c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20733",
"triggerID" : "898d03c01442d0b4ac84056f25ff49f1f9aba0c0",
"triggerType" : "PUSH"
}, {
"hash" : "c359d7d70cb6e34ce4d62b2f71f39b91b49ea334",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21070",
"triggerID" : "c359d7d70cb6e34ce4d62b2f71f39b91b49ea334",
"triggerType" : "PUSH"
}, {
"hash" : "32469364d39eebf69fb001955aa2cccdfc772f1c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21087",
"triggerID" : "32469364d39eebf69fb001955aa2cccdfc772f1c",
"triggerType" : "PUSH"
}, {
"hash" : "80725367a7e21160545ffa27ec1275a32e47e7c4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21092",
"triggerID" : "80725367a7e21160545ffa27ec1275a32e47e7c4",
"triggerType" : "PUSH"
}, {
"hash" : "5e60b3d12b40a04006d3697fa99538e9e494b96c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21108",
"triggerID" : "5e60b3d12b40a04006d3697fa99538e9e494b96c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 80725367a7e21160545ffa27ec1275a32e47e7c4 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21092)
* 5e60b3d12b40a04006d3697fa99538e9e494b96c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21108)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7052] Fix partition key validation for custom key generators. [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10014:
URL: https://github.com/apache/hudi/pull/10014#issuecomment-1821554730
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "898d03c01442d0b4ac84056f25ff49f1f9aba0c0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20733",
"triggerID" : "898d03c01442d0b4ac84056f25ff49f1f9aba0c0",
"triggerType" : "PUSH"
}, {
"hash" : "c359d7d70cb6e34ce4d62b2f71f39b91b49ea334",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21070",
"triggerID" : "c359d7d70cb6e34ce4d62b2f71f39b91b49ea334",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 898d03c01442d0b4ac84056f25ff49f1f9aba0c0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20733)
* c359d7d70cb6e34ce4d62b2f71f39b91b49ea334 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21070)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7052] Fix partition key validation for custom key generators. [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10014:
URL: https://github.com/apache/hudi/pull/10014#issuecomment-1822078574
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "898d03c01442d0b4ac84056f25ff49f1f9aba0c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20733",
"triggerID" : "898d03c01442d0b4ac84056f25ff49f1f9aba0c0",
"triggerType" : "PUSH"
}, {
"hash" : "c359d7d70cb6e34ce4d62b2f71f39b91b49ea334",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21070",
"triggerID" : "c359d7d70cb6e34ce4d62b2f71f39b91b49ea334",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c359d7d70cb6e34ce4d62b2f71f39b91b49ea334 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21070)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7052] Fix partition key validation for custom key generators. [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10014:
URL: https://github.com/apache/hudi/pull/10014#issuecomment-1822183538
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "898d03c01442d0b4ac84056f25ff49f1f9aba0c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20733",
"triggerID" : "898d03c01442d0b4ac84056f25ff49f1f9aba0c0",
"triggerType" : "PUSH"
}, {
"hash" : "c359d7d70cb6e34ce4d62b2f71f39b91b49ea334",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21070",
"triggerID" : "c359d7d70cb6e34ce4d62b2f71f39b91b49ea334",
"triggerType" : "PUSH"
}, {
"hash" : "32469364d39eebf69fb001955aa2cccdfc772f1c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "32469364d39eebf69fb001955aa2cccdfc772f1c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c359d7d70cb6e34ce4d62b2f71f39b91b49ea334 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21070)
* 32469364d39eebf69fb001955aa2cccdfc772f1c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7052] Fix partition key validation for custom key generators. [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10014:
URL: https://github.com/apache/hudi/pull/10014#issuecomment-1822191008
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "898d03c01442d0b4ac84056f25ff49f1f9aba0c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20733",
"triggerID" : "898d03c01442d0b4ac84056f25ff49f1f9aba0c0",
"triggerType" : "PUSH"
}, {
"hash" : "c359d7d70cb6e34ce4d62b2f71f39b91b49ea334",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21070",
"triggerID" : "c359d7d70cb6e34ce4d62b2f71f39b91b49ea334",
"triggerType" : "PUSH"
}, {
"hash" : "32469364d39eebf69fb001955aa2cccdfc772f1c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21087",
"triggerID" : "32469364d39eebf69fb001955aa2cccdfc772f1c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c359d7d70cb6e34ce4d62b2f71f39b91b49ea334 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21070)
* 32469364d39eebf69fb001955aa2cccdfc772f1c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21087)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7052] Fix partition key validation for custom key generators. [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10014:
URL: https://github.com/apache/hudi/pull/10014#issuecomment-1822398148
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "898d03c01442d0b4ac84056f25ff49f1f9aba0c0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=20733",
"triggerID" : "898d03c01442d0b4ac84056f25ff49f1f9aba0c0",
"triggerType" : "PUSH"
}, {
"hash" : "c359d7d70cb6e34ce4d62b2f71f39b91b49ea334",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21070",
"triggerID" : "c359d7d70cb6e34ce4d62b2f71f39b91b49ea334",
"triggerType" : "PUSH"
}, {
"hash" : "32469364d39eebf69fb001955aa2cccdfc772f1c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21087",
"triggerID" : "32469364d39eebf69fb001955aa2cccdfc772f1c",
"triggerType" : "PUSH"
}, {
"hash" : "80725367a7e21160545ffa27ec1275a32e47e7c4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21092",
"triggerID" : "80725367a7e21160545ffa27ec1275a32e47e7c4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 32469364d39eebf69fb001955aa2cccdfc772f1c Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21087)
* 80725367a7e21160545ffa27ec1275a32e47e7c4 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21092)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7052] Fix partition key validation for custom key generators. [hudi]
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on PR #10014:
URL: https://github.com/apache/hudi/pull/10014#issuecomment-1823817928
<img width="1219" alt="image" src="https://github.com/apache/hudi/assets/513218/f0efc544-a78a-4ee3-bed7-f403aea335fb">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7052] Fix partition key validation for custom key generators. [hudi]
Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on code in PR #10014:
URL: https://github.com/apache/hudi/pull/10014#discussion_r1399548286
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala:
##########
@@ -263,14 +263,14 @@ class HoodieSparkSqlWriterInternal {
}
}
+ val keyGenerator = HoodieSparkKeyGeneratorFactory.createKeyGenerator(new TypedProperties(hoodieConfig.getProps))
Review Comment:
we can't instantiate key gen in driver due to auto record key generation.
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/util/SparkKeyGenUtils.scala:
##########
@@ -34,26 +34,26 @@ object SparkKeyGenUtils {
* @return partition columns
*/
def getPartitionColumns(props: TypedProperties): String = {
- val keyGeneratorClass = getKeyGeneratorClassName(props)
- getPartitionColumns(keyGeneratorClass, props)
+ val keyGenerator = HoodieSparkKeyGeneratorFactory.createKeyGenerator(props)
Review Comment:
we can't do this. For auto key geneator, the key gen has to be invoked from within executor. can we avoid instantiating key gen class here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org