You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "yejiabao (Code Review)" <ge...@cloudera.org> on 2021/10/06 07:58:02 UTC
[kudu-CR] [tablet] KUDU-3325 When wal is deleted, fault recovery and load balancing are abnormal
yejiabao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17907
Change subject: [tablet] KUDU-3325 When wal is deleted, fault recovery and load balancing are abnormal
......................................................................
[tablet] KUDU-3325 When wal is deleted, fault recovery and load balancing are abnormal
This patch is to fix when wal be deleted (when the wal/cmate term disagreement or other issues make the wal file cannot to use) , the request raft config change be ignore, so that some functions abnoraml (e.g. tablet fault recovery, rebalance).
Here we use opid_index recorded in cmeta to init index in wal when tablet bootstrap, and create a "NO_OP" message flush into disk.
Change-Id: I1f3d5a5c3634dc4b0ad7f1456b45a999d05b0652
---
M src/kudu/tablet/tablet_bootstrap.cc
1 file changed, 37 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/17907/1
--
To view, visit http://gerrit.cloudera.org:8080/17907
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1f3d5a5c3634dc4b0ad7f1456b45a999d05b0652
Gerrit-Change-Number: 17907
Gerrit-PatchSet: 1
Gerrit-Owner: yejiabao <49...@qq.com>
[kudu-CR] [tablet] KUDU-3325 When wal is deleted, fault recovery and load balancing are abnormal
Posted by "yejiabao (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17907
to look at the new patch set (#4).
Change subject: [tablet] KUDU-3325 When wal is deleted, fault recovery and load balancing are abnormal
......................................................................
[tablet] KUDU-3325 When wal is deleted,
fault recovery and load balancing are abnormal
This patch is to fix when wal be deleted (when the
wal/cmate term disagreement or other issues make the
wal file cannot to use) , the request raft config
change be ignore, so that some functions abnoraml
(e.g. tablet fault recovery, rebalance).
Here we use opid_index recorded in cmeta to init
index in wal when tablet bootstrap,
and create a "NO_OP" message flush into disk.
Change-Id: I1f3d5a5c3634dc4b0ad7f1456b45a999d05b0652
---
M src/kudu/tablet/tablet_bootstrap.cc
1 file changed, 44 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/17907/4
--
To view, visit http://gerrit.cloudera.org:8080/17907
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1f3d5a5c3634dc4b0ad7f1456b45a999d05b0652
Gerrit-Change-Number: 17907
Gerrit-PatchSet: 4
Gerrit-Owner: yejiabao <ye...@huawei.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tablet] KUDU-3325 When wal is deleted, fault recovery and load balancing are abnormal
Posted by "yejiabao (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17907
to look at the new patch set (#2).
Change subject: [tablet] KUDU-3325 When wal is deleted, fault recovery and load balancing are abnormal
......................................................................
[tablet] KUDU-3325 When wal is deleted, fault recovery and load balancing are abnormal
This patch is to fix when wal be deleted (when the
wal/cmate term disagreement or other issues make the
wal file cannot to use) , the request raft config
change be ignore, so that some functions abnoraml
(e.g. tablet fault recovery, rebalance).
Here we use opid_index recorded in cmeta to init
index in wal when tablet bootstrap,
and create a "NO_OP" message flush into disk.
Change-Id: I1f3d5a5c3634dc4b0ad7f1456b45a999d05b0652
---
M src/kudu/tablet/tablet_bootstrap.cc
1 file changed, 37 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/17907/2
--
To view, visit http://gerrit.cloudera.org:8080/17907
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1f3d5a5c3634dc4b0ad7f1456b45a999d05b0652
Gerrit-Change-Number: 17907
Gerrit-PatchSet: 2
Gerrit-Owner: yejiabao <49...@qq.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tablet] KUDU-3325 When wal is deleted, fault recovery and load balancing are abnormal
Posted by "yejiabao (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17907
to look at the new patch set (#3).
Change subject: [tablet] KUDU-3325 When wal is deleted, fault recovery and load balancing are abnormal
......................................................................
[tablet] KUDU-3325 When wal is deleted,
fault recovery and load balancing are abnormal
This patch is to fix when wal be deleted (when the
wal/cmate term disagreement or other issues make the
wal file cannot to use) , the request raft config
change be ignore, so that some functions abnoraml
(e.g. tablet fault recovery, rebalance).
Here we use opid_index recorded in cmeta to init
index in wal when tablet bootstrap,
and create a "NO_OP" message flush into disk.
Change-Id: I1f3d5a5c3634dc4b0ad7f1456b45a999d05b0652
---
M src/kudu/tablet/tablet_bootstrap.cc
1 file changed, 38 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/17907/3
--
To view, visit http://gerrit.cloudera.org:8080/17907
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1f3d5a5c3634dc4b0ad7f1456b45a999d05b0652
Gerrit-Change-Number: 17907
Gerrit-PatchSet: 3
Gerrit-Owner: yejiabao <49...@qq.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tablet] KUDU-3325 When wal is deleted, fault recovery and load balancing are abnormal
Posted by "yejiabao (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17907
to look at the new patch set (#5).
Change subject: [tablet] KUDU-3325 When wal is deleted, fault recovery and load balancing are abnormal
......................................................................
[tablet] KUDU-3325 When wal is deleted,
fault recovery and load balancing are abnormal
This patch is to fix when wal be deleted (when the
wal/cmate term disagreement or other issues make the
wal file cannot to use) , the request raft config
change be ignore, so that some functions abnoraml
(e.g. tablet fault recovery, rebalance).
Here we use opid_index recorded in cmeta to init
index in wal when tablet bootstrap,
and create a "NO_OP" message flush into disk.
Change-Id: I1f3d5a5c3634dc4b0ad7f1456b45a999d05b0652
---
M src/kudu/tablet/tablet_bootstrap.cc
1 file changed, 44 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/17907/5
--
To view, visit http://gerrit.cloudera.org:8080/17907
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1f3d5a5c3634dc4b0ad7f1456b45a999d05b0652
Gerrit-Change-Number: 17907
Gerrit-PatchSet: 5
Gerrit-Owner: yejiabao <ye...@huawei.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tablet] KUDU-3325 When wal is deleted, fault recovery and load balancing are abnormal
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17907 )
Change subject: [tablet] KUDU-3325 When wal is deleted, fault recovery and load balancing are abnormal
......................................................................
Patch Set 3:
I apologize for the late response.
Per comments on
https://issues.apache.org/jira/browse/KUDU-3325 it seems this mode of operation should be there only for some corner use cases, so it should not be enabled by default.
In other words, even if having this new behavior, it should be gated by some run-time flag.
--
To view, visit http://gerrit.cloudera.org:8080/17907
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f3d5a5c3634dc4b0ad7f1456b45a999d05b0652
Gerrit-Change-Number: 17907
Gerrit-PatchSet: 3
Gerrit-Owner: yejiabao <ye...@huawei.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 21 Mar 2022 17:52:03 +0000
Gerrit-HasComments: No