You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Sravya Tirukkovalur <sr...@cloudera.com> on 2016/04/12 12:07:16 UTC
Review Request 46081: SENTRY-1181: Lock
SentryAuthorizationInfo#processUpdates
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46081/
-----------------------------------------------------------
Review request for sentry.
Repository: sentry
Description
-------
If processing of update on NN takes more than the cache interval time(default:30 secs), it is possible that two updates will be processed parallely leading to unexpected behavior. We should instead lock the processing of updates so that we ensure they happen sequentially. Also while doing so, we should add a flag to make sure we should never go into stale mode while processing an update.
Diffs
-----
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/UpdateableAuthzPaths.java 8fc5470088853e639e39a35fe930ca805f8ff08e
sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryAuthorizationInfo.java c2416c1cf873484321cc7281bd46197d37a4195d
sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/UpdateableAuthzPermissions.java 33581b72369d6a46eefcabd0eb658e4213076c7c
Diff: https://reviews.apache.org/r/46081/diff/
Testing
-------
Thanks,
Sravya Tirukkovalur
Re: Review Request 46081: SENTRY-1181: Lock
SentryAuthorizationInfo#processUpdates
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46081/
-----------------------------------------------------------
(Updated April 12, 2016, 7:58 p.m.)
Review request for sentry.
Changes
-------
Fixing PMD issue
Repository: sentry
Description
-------
If processing of update on NN takes more than the cache interval time(default:30 secs), it is possible that two updates will be processed parallely leading to unexpected behavior. We should instead lock the processing of updates so that we ensure they happen sequentially. Also while doing so, we should add a flag to make sure we should never go into stale mode while processing an update.
Diffs (updated)
-----
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/UpdateableAuthzPaths.java 8fc5470088853e639e39a35fe930ca805f8ff08e
sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryAuthorizationInfo.java c2416c1cf873484321cc7281bd46197d37a4195d
sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/UpdateableAuthzPermissions.java 33581b72369d6a46eefcabd0eb658e4213076c7c
Diff: https://reviews.apache.org/r/46081/diff/
Testing
-------
Thanks,
Sravya Tirukkovalur