[GitHub] zentol opened a new pull request #7341: [FLINK-11026][kafka][SQL] Rework kafka sql-client jar creation

[GitBox <gi...@apache.org>]

zentol opened a new pull request #7341: [FLINK-11026][kafka][SQL] Rework kafka sql-client jar creation 
URL: https://github.com/apache/flink/pull/7341
 
 
   ## What is the purpose of the change
   
   This PR reworks the the generation of sql-client jars for the kafka connectors, similar to #7251.
   The packing of said jar was moved into a separate module, which allows us to provide distinct NOTICE files for both jars.
   
   ## Brief change log
   
   * move shade-plugin logic for sql-jars into separate `flink-sql-connector-kafka...` modules for 0.9+
     * configuration now uses the `shade-flink` execution
        * `shadedArtifactAttached` is now false (inherited), since we only want a single artifact
        * `shadedClassifierName` was removed, since it's redundant
        * `combine.children="append"` setting for the `artifactSet` was removed since it server no purpose
        * `shadeTestJar` is now false for the kafka 2.0 connector, due to a recurring issue that occurs when a test jar is shaded, but services are contained in the main jar (it's weird)
        * the artifactSet for each module now contains one additional entry; the main module to package (which was implicitly included before)
     * b
   * add new modules to sql-jars profile in `flink-connectors`
   * update sql-client E2E dependencies to refer to flink-sql-connector modules instead
   * update documentation
   
   
   ## Verifying this change
   
   * ran E2E tests: https://travis-ci.org/zentol/flink/builds/470006280
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services