You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Johan Oskarsson (JIRA)" <ji...@apache.org> on 2010/07/13 18:43:51 UTC

[jira] Created: (CASSANDRA-1272) Don't stop server from starting if version.properties is missing

Don't stop server from starting if version.properties is missing
----------------------------------------------------------------

                 Key: CASSANDRA-1272
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1272
             Project: Cassandra
          Issue Type: Improvement
          Components: Core
            Reporter: Johan Oskarsson


To reduce potential problems getting a development environment setup in an IDE we should let Cassandra start if there is no version.properties present in the classpath.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1272) Don't stop server from starting if version.properties is missing

Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887862#action_12887862 ] 

Johan Oskarsson commented on CASSANDRA-1272:
--------------------------------------------

The version.properties end up in the classes dir though, I don't want to mix the eclipse built classes with the ones from ant. That has been a recipe for disaster in the past at least.

> Don't stop server from starting if version.properties is missing
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-1272
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1272
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Johan Oskarsson
>             Fix For: 0.7
>
>         Attachments: CASSANDRA-1272.patch
>
>
> To reduce potential problems getting a development environment setup in an IDE we should let Cassandra start if there is no version.properties present in the classpath.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1272) Don't stop server from starting if version.properties is missing

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896358#action_12896358 ] 

Hudson commented on CASSANDRA-1272:
-----------------------------------

Integrated in Cassandra #510 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/510/])
    Don't stop server from starting if version.properties is missing.  patch by johano and jbellis for CASSANDRA-1272


> Don't stop server from starting if version.properties is missing
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-1272
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1272
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Johan Oskarsson
>            Assignee: Matthew F. Dennis
>             Fix For: 0.7 beta 1
>
>         Attachments: 1272-trunk.txt, CASSANDRA-1272.patch
>
>
> To reduce potential problems getting a development environment setup in an IDE we should let Cassandra start if there is no version.properties present in the classpath.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1272) Don't stop server from starting if version.properties is missing

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895300#action_12895300 ] 

Jonathan Ellis commented on CASSANDRA-1272:
-------------------------------------------

I think the difference between this and the avro code is, you get a compile-time error with avro which makes it relatively clear where the problem is.  With this, the server builds but then dies when started, which is frustrating for new developers.  So I'm committing a version of Johan's patch too.

> Don't stop server from starting if version.properties is missing
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-1272
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1272
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Johan Oskarsson
>            Assignee: Matthew F. Dennis
>             Fix For: 0.7 beta 1
>
>         Attachments: 1272-trunk.txt, CASSANDRA-1272.patch
>
>
> To reduce potential problems getting a development environment setup in an IDE we should let Cassandra start if there is no version.properties present in the classpath.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1272) Don't stop server from starting if version.properties is missing

Posted by "Jeremy Hanna (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888084#action_12888084 ] 

Jeremy Hanna commented on CASSANDRA-1272:
-----------------------------------------

If people want to hack on Cassandra - this is another barrier.  They won't be able to run (or debug) Cassandra within their IDE until they understand through a cryptic error that they don't have version.properties in their classpath.  I don't know about a special case in the code, but IMO something should be done to either make it simpler or more obvious to get that onto the classpath.

> Don't stop server from starting if version.properties is missing
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-1272
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1272
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Johan Oskarsson
>            Assignee: Matthew F. Dennis
>             Fix For: 0.7
>
>         Attachments: CASSANDRA-1272.patch
>
>
> To reduce potential problems getting a development environment setup in an IDE we should let Cassandra start if there is no version.properties present in the classpath.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1272) Don't stop server from starting if version.properties is missing

Posted by "Matthew F. Dennis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887909#action_12887909 ] 

Matthew F. Dennis commented on CASSANDRA-1272:
----------------------------------------------

I think gdusbabek added version.properties as another resource in eclipse/intellij to solve this

I'm not really a fan of adding code to special case because the way I look at it, the product depends on it and it is exposed via the API.

> Don't stop server from starting if version.properties is missing
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-1272
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1272
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Johan Oskarsson
>            Assignee: Matthew F. Dennis
>             Fix For: 0.7
>
>         Attachments: CASSANDRA-1272.patch
>
>
> To reduce potential problems getting a development environment setup in an IDE we should let Cassandra start if there is no version.properties present in the classpath.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1272) Don't stop server from starting if version.properties is missing

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888897#action_12888897 ] 

Gary Dusbabek commented on CASSANDRA-1272:
------------------------------------------

I created another Intellij module that contains version.properties and gets included in the CP when I build using my IDE.  It works for me and is just as painful as the configuration modules I have to maintain to run cassandra easily from the IDE.  I do keep my ant and IDE class files separated too.

What I'd rather see is an ant task that generates the file to a place specified by the developers ant.properties (the default would, of course, be ${build.classes}/o/a/c/c/version.properties).



> Don't stop server from starting if version.properties is missing
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-1272
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1272
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Johan Oskarsson
>            Assignee: Matthew F. Dennis
>             Fix For: 0.7
>
>         Attachments: CASSANDRA-1272.patch
>
>
> To reduce potential problems getting a development environment setup in an IDE we should let Cassandra start if there is no version.properties present in the classpath.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1272) Don't stop server from starting if version.properties is missing

Posted by "Matthew F. Dennis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthew F. Dennis updated CASSANDRA-1272:
-----------------------------------------

    Attachment: 1272-trunk.txt

1272-trunk.txt allows setting version.properties.dir=place/you/want/the/file in build.properties


> Don't stop server from starting if version.properties is missing
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-1272
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1272
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Johan Oskarsson
>            Assignee: Matthew F. Dennis
>             Fix For: 0.7 beta 1
>
>         Attachments: 1272-trunk.txt, CASSANDRA-1272.patch
>
>
> To reduce potential problems getting a development environment setup in an IDE we should let Cassandra start if there is no version.properties present in the classpath.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1272) Don't stop server from starting if version.properties is missing

Posted by "Gary Dusbabek (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893376#action_12893376 ] 

Gary Dusbabek commented on CASSANDRA-1272:
------------------------------------------

+1 committed.

For the curious:  ant createVersionPropFile -Dversion.properties.dir=/path/to/your/file

> Don't stop server from starting if version.properties is missing
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-1272
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1272
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Johan Oskarsson
>            Assignee: Matthew F. Dennis
>             Fix For: 0.7 beta 1
>
>         Attachments: 1272-trunk.txt, CASSANDRA-1272.patch
>
>
> To reduce potential problems getting a development environment setup in an IDE we should let Cassandra start if there is no version.properties present in the classpath.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1272) Don't stop server from starting if version.properties is missing

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-1272:
--------------------------------------

    Fix Version/s: 0.7

Since we already require running 'ant' before loading into an ide (for avro and the antlr stuff in the cli), I'm not sure special-casing version.properties is a big win...

> Don't stop server from starting if version.properties is missing
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-1272
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1272
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Johan Oskarsson
>             Fix For: 0.7
>
>         Attachments: CASSANDRA-1272.patch
>
>
> To reduce potential problems getting a development environment setup in an IDE we should let Cassandra start if there is no version.properties present in the classpath.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1272) Don't stop server from starting if version.properties is missing

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895250#action_12895250 ] 

Hudson commented on CASSANDRA-1272:
-----------------------------------

Integrated in Cassandra #509 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/509/])
    

> Don't stop server from starting if version.properties is missing
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-1272
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1272
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Johan Oskarsson
>            Assignee: Matthew F. Dennis
>             Fix For: 0.7 beta 1
>
>         Attachments: 1272-trunk.txt, CASSANDRA-1272.patch
>
>
> To reduce potential problems getting a development environment setup in an IDE we should let Cassandra start if there is no version.properties present in the classpath.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1272) Don't stop server from starting if version.properties is missing

Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johan Oskarsson updated CASSANDRA-1272:
---------------------------------------

    Attachment: CASSANDRA-1272.patch

This patch simply returns "Unknown" if the version.properties is not present.

> Don't stop server from starting if version.properties is missing
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-1272
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1272
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Johan Oskarsson
>         Attachments: CASSANDRA-1272.patch
>
>
> To reduce potential problems getting a development environment setup in an IDE we should let Cassandra start if there is no version.properties present in the classpath.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (CASSANDRA-1272) Don't stop server from starting if version.properties is missing

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis reassigned CASSANDRA-1272:
-----------------------------------------

    Assignee: Matthew F. Dennis

> Don't stop server from starting if version.properties is missing
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-1272
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1272
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Johan Oskarsson
>            Assignee: Matthew F. Dennis
>             Fix For: 0.7
>
>         Attachments: CASSANDRA-1272.patch
>
>
> To reduce potential problems getting a development environment setup in an IDE we should let Cassandra start if there is no version.properties present in the classpath.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.