[GitHub] [superset] rusackas commented on a diff in pull request #24322: chore: Deprecates some NVD3 charts in 3.0

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on code in PR #24322:
URL: https://github.com/apache/superset/pull/24322#discussion_r1223296386


##########
superset-frontend/plugins/legacy-preset-chart-nvd3/src/Pie/index.js:
##########
@@ -24,11 +24,15 @@ import controlPanel from './controlPanel';
 const metadata = new ChartMetadata({
   credits: ['http://nvd3.org'],
   description: '',
-  name: t('Pie Chart'),
+  name: t('Pie Chart (deprecated)'),

Review Comment:
   Hmm, I wonder if it's fair to add `deprecated: true` to the metadata here, which would hide it from the viz gallery. Maybe we should gather some thoughts on this at Town Hall tomorrow? I'll stick it on the agenda.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org