You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/21 06:34:23 UTC
[GitHub] [superset] MaxHuiYYDS opened a new pull request #16389: fix(dashboard-ui): undo and redo buttons weird alignment
MaxHuiYYDS opened a new pull request #16389:
URL: https://github.com/apache/superset/pull/16389
### SUMMARY
I think it related to [PR #13037](https://github.com/apache/superset/pull/13037), which help add 8px marginRight when there are more than 1 button in a group. But it may not apply for [#16365
](https://github.com/apache/superset/issues/16365), in order not affect other components, I add the showMarginRight prop in Button Component.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue: Fixes #16365
- [ x] Required feature flags:
- [ ] Changes UI
- [x ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ x] Migration is atomic, supports rollback & is backwards-compatible
- [ x] Confirm DB migration upgrade and downgrade tested
- [ x] Runtime estimates and downtime expectations provided
- [ x] Introduces new feature or API
- [ x] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] MaxHuiYYDS closed pull request #16389: fix(1:dashboard-ui,2:Explore control panel): 1:undo and redo buttons weird alignment. 2:Keyboard navigation in Explore control panel
Posted by GitBox <gi...@apache.org>.
MaxHuiYYDS closed pull request #16389:
URL: https://github.com/apache/superset/pull/16389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] MaxHuiYYDS commented on pull request #16389: fix(1:dashboard-ui,2:Explore control panel): 1:undo and redo buttons weird alignment. 2:Keyboard navigation in Explore control panel
Posted by GitBox <gi...@apache.org>.
MaxHuiYYDS commented on pull request #16389:
URL: https://github.com/apache/superset/pull/16389#issuecomment-904352895
@junlincc @ktmud , done, please help review https://github.com/apache/superset/pull/16418 and https://github.com/apache/superset/pull/16417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #16389: fix(1:dashboard-ui,2:Explore control panel): 1:undo and redo buttons weird alignment. 2:Keyboard navigation in Explore control panel
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #16389:
URL: https://github.com/apache/superset/pull/16389#issuecomment-904210342
@MaxHuiYYDS please do split this PR into 2, and attach separate issues to them. 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] MaxHuiYYDS commented on pull request #16389: fix(1:dashboard-ui,2:Explore control panel): 1:undo and redo buttons weird alignment. 2:Keyboard navigation in Explore control panel
Posted by GitBox <gi...@apache.org>.
MaxHuiYYDS commented on pull request #16389:
URL: https://github.com/apache/superset/pull/16389#issuecomment-903405405
@junlincc @ktmud Please help review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] MaxHuiYYDS closed pull request #16389: fix(1:dashboard-ui,2:Explore control panel): 1:undo and redo buttons weird alignment. 2:Keyboard navigation in Explore control panel
Posted by GitBox <gi...@apache.org>.
MaxHuiYYDS closed pull request #16389:
URL: https://github.com/apache/superset/pull/16389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #16389: fix(1:dashboard-ui,2:Explore control panel): 1:undo and redo buttons weird alignment. 2:Keyboard navigation in Explore control panel
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #16389:
URL: https://github.com/apache/superset/pull/16389#issuecomment-903902455
@MaxHuiYYDS Thanks for the contribution. Could you split this into two PRs? It seems the two changes are not related.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org