[GitHub] [arrow] icexelloss commented on a diff in pull request #33909: GH-33899: [C++] Add NamedTapRel relation as a Substrait extension

["icexelloss (via GitHub)" <gi...@apache.org>]

icexelloss commented on code in PR #33909:
URL: https://github.com/apache/arrow/pull/33909#discussion_r1095008046


##########
cpp/proto/substrait/extension_rels.proto:
##########
@@ -44,3 +44,17 @@ message AsOfJoinRel {
     repeated .substrait.Expression by = 2;
   }
 }
+
+// Named tap relation
+//
+// A tap is a relation having a single input relation that it passes through, while also
+// causing some side-effect, e.g., writing to external storage.
+message NamedTapRel {
+  // The kind of tap
+  string kind = 1;
+  // A name used to configure the tap, e.g., a URI defining the destination of writing
+  string name = 2;
+  // Column names for the tap's output. If specified there must be one name per field.
+  // If empty, field names will be automatically generated.

Review Comment:
   Why don't we make the columns required - i.e., if it's missing or doesn't match the number of fields in the data then it's an illegal message? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org