You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/03 14:34:10 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #4647: 4.14 forceha issues
ustcweizhou opened a new pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647
### Description
This PR fixes two issues. see description of each commit
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-839532980
<b>Trillian test result (tid-662)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45390 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4647-t662-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 81 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_deploy_kubernetes_cluster | `Failure` | 3605.37 | test_kubernetes_clusters.py
test_02_invalid_upgrade_kubernetes_cluster | `Failure` | 3614.58 | test_kubernetes_clusters.py
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 84.00 | test_kubernetes_clusters.py
test_01_migrate_VM_and_root_volume | `Error` | 61.11 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 51.12 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-838230050
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#discussion_r570161351
##########
File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -4498,7 +4498,7 @@ private void handlePowerOffReportWithNoPendingJobsOnVM(final VMInstanceVO vm) {
String.format("VM %s is at %s and we received a %s report while there is no pending jobs on it"
, vm.getInstanceName(), vm.getState(), vm.getPowerState()));
}
- if(vm.isHaEnabled() && vm.getState() == State.Running
+ if((HighAvailabilityManager.ForceHA.value() || vm.isHaEnabled()) && vm.getState() == State.Running
Review comment:
@harikrishna-patnala yes, it is a cluster-scope setting.
But cloudstack does not consider it before.
```
_forceHA = ForceHA.value();
```
same as other cluster-scope settings in https://github.com/apache/cloudstack/blob/master/engine/components-api/src/main/java/com/cloud/ha/HighAvailabilityManager.java.
I am wondering if we should fix all of them in a pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-840362214
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-838228350
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-773185617
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2646
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#discussion_r607551300
##########
File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -4498,7 +4498,7 @@ private void handlePowerOffReportWithNoPendingJobsOnVM(final VMInstanceVO vm) {
String.format("VM %s is at %s and we received a %s report while there is no pending jobs on it"
, vm.getInstanceName(), vm.getState(), vm.getPowerState()));
}
- if(vm.isHaEnabled() && vm.getState() == State.Running
+ if((HighAvailabilityManager.ForceHA.value() || vm.isHaEnabled()) && vm.getState() == State.Running
Review comment:
@weizhouapache can you address the scope issue? Or change scope of config key to be global than cluster specific of it never supported cluster level setting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-773070906
<b>Trillian test result (tid-3485)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43360 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4647-t3485-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_deploy_kubernetes_cluster | `Failure` | 3617.42 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 178.04 | test_kubernetes_clusters.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-838169444
> @weizhouapache is this still applicable for 4.15.1, I ask as this is raised for 4.14.2
@rhtyd yes. the issue exists in 4.14 LTS and 4.15 LTS both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-839730599
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: debian. SL-JID 589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-826616057
ping @weizhouapache cc @ravening @Pearl1594 @Spaceman1984 @shwstppr - should we consider this for 4.15.1, can you provide comments on testing/reviewing this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-837036695
@weizhouapache is this still applicable for 4.15.1, I ask as this is raised for 4.14.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-774296269
<b>Trillian test result (tid-3499)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29514 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4647-t3499-kvm-centos7.zip
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-772708117
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-839714635
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-774010312
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-838374722
@rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-772686260
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-839713853
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-772685299
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-774010744
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-772703846
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2645
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-840683758
<b>Trillian test result (tid-677)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33101 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4647-t677-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_migrate_VM_and_root_volume | `Error` | 69.21 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 53.09 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-839532442
@harikrishna-patnala @shwstppr cool, thanks for review and testing !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-840361908
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-840687871
Failures not related to PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-839924599
<b>Trillian test result (tid-663)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 75339 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4647-t663-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 74 look OK, 9 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_05_ping_in_cpvm_success | `Failure` | 14.73 | test_diagnostics.py
test_01_deploy_kubernetes_cluster | `Failure` | 3606.15 | test_kubernetes_clusters.py
test_02_invalid_upgrade_kubernetes_cluster | `Failure` | 3601.65 | test_kubernetes_clusters.py
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 46.27 | test_kubernetes_clusters.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 1511.35 | test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 591.02 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 634.82 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-838373055
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-773160322
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-773070906
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-773160322
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on a change in pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#discussion_r569929451
##########
File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -4498,7 +4498,7 @@ private void handlePowerOffReportWithNoPendingJobsOnVM(final VMInstanceVO vm) {
String.format("VM %s is at %s and we received a %s report while there is no pending jobs on it"
, vm.getInstanceName(), vm.getState(), vm.getPowerState()));
}
- if(vm.isHaEnabled() && vm.getState() == State.Running
+ if((HighAvailabilityManager.ForceHA.value() || vm.isHaEnabled()) && vm.getState() == State.Running
Review comment:
ForceHA setting is scoped to cluster, I think we need to use ForceHA.valueIn(clusterid) method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#discussion_r570161351
##########
File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -4498,7 +4498,7 @@ private void handlePowerOffReportWithNoPendingJobsOnVM(final VMInstanceVO vm) {
String.format("VM %s is at %s and we received a %s report while there is no pending jobs on it"
, vm.getInstanceName(), vm.getState(), vm.getPowerState()));
}
- if(vm.isHaEnabled() && vm.getState() == State.Running
+ if((HighAvailabilityManager.ForceHA.value() || vm.isHaEnabled()) && vm.getState() == State.Running
Review comment:
@harikrishna-patnala yes, it is a cluster-scope setting.
But cloudstack does not consider it before.
```
_forceHA = ForceHA.value();
```
same as other cluster-scope settings in https://github.com/apache/cloudstack/blob/master/engine/components-api/src/main/java/com/cloud/ha/HighAvailabilityManager.java.
I am wondering if we should fix all of them in a pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-773160950
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-838276087
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: debian. SL-JID 580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#issuecomment-772707080
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #4647: forceha: fix two issues when (1)stop vm from inside (2) force remove host
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on a change in pull request #4647:
URL: https://github.com/apache/cloudstack/pull/4647#discussion_r630729893
##########
File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -4498,7 +4498,7 @@ private void handlePowerOffReportWithNoPendingJobsOnVM(final VMInstanceVO vm) {
String.format("VM %s is at %s and we received a %s report while there is no pending jobs on it"
, vm.getInstanceName(), vm.getState(), vm.getPowerState()));
}
- if(vm.isHaEnabled() && vm.getState() == State.Running
+ if((HighAvailabilityManager.ForceHA.value() || vm.isHaEnabled()) && vm.getState() == State.Running
Review comment:
If we change it to global, then we may miss setting this back to cluster when we want to fix all other global settings in that Manager. This configuration parameter makes more sense to be scoped to cluster. May be as @weizhouapache mentioned, we need to fix all other settings in another PR. I'm fine with this for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org