You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/05 06:25:10 UTC

[GitHub] [cloudstack] shwstppr opened a new issue #4654: VM's name and display name in UI

shwstppr opened a new issue #4654:
URL: https://github.com/apache/cloudstack/issues/4654


   In new UI, for the VM detail view shows VM's display name while VM's name is shown in the list view. It is fine when VM is deployed from the UI itself but name and display name can have different values when deployed from cmk.
   
   Old UI used to show `name` of the VM in the list view and there was no info tab in detail view,
   ![Screenshot from 2021-02-05 11-31-12](https://user-images.githubusercontent.com/153340/106996466-11c11d00-67a7-11eb-84bb-0734d83df386.png)
   ![Screenshot from 2021-02-05 11-31-26](https://user-images.githubusercontent.com/153340/106996481-15ed3a80-67a7-11eb-9352-6b236bf533bc.png)
   
   New UI
   ![Screenshot from 2021-02-05 11-40-24](https://user-images.githubusercontent.com/153340/106996490-1be31b80-67a7-11eb-9cda-4de4c02ec7ba.png)
   ![Screenshot from 2021-02-05 11-40-43](https://user-images.githubusercontent.com/153340/106996526-2d2c2800-67a7-11eb-8690-8cf809d7f684.png)
   
   Few queries here,
   - Is this behaviour okay from the user perspective?
   - Should UI display VM's `displayname` in the list view?
   - Should new UI show VM's `name` in the info tab in detail view?
   
   
   ##### ISSUE TYPE
   <!-- Pick one below and delete the rest -->
    * Other
   
   ##### COMPONENT NAME
   ~~~
   UI
   ~~~
   
   ##### CLOUDSTACK VERSION
   ~~~
   4.15.0
   ~~~
   
   ##### CONFIGURATION
   N/A
   
   
   ##### OS / ENVIRONMENT
   N/A
   
   
   ##### SUMMARY
   <!-- Explain the problem/feature briefly -->
   
   
   ##### STEPS TO REPRODUCE
   <!--
   Deploy a VM using cmk while providing different name and displayname value
   ~~~
   
   ~~~
   
   <!-- You can also paste gist.github.com links for larger files -->
   
   ##### EXPECTED RESULTS
   <!-- What did you expect to happen when running the steps above? -->
   
   ~~~
   
   ~~~
   
   ##### ACTUAL RESULTS
   <!-- What actually happened? -->
   
   <!-- Paste verbatim command output between quotes below -->
   ~~~
   
   ~~~
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on issue #4654: VM's name and display name in UI

Posted by GitBox <gi...@apache.org>.

shwstppr commented on issue #4654:
URL: https://github.com/apache/cloudstack/issues/4654#issuecomment-773823098


   @harikrishna-patnala @vladimirpetrov @PaulAngus @weizhouapache @ravening @rhtyd @davidjumani @andrijapanicsb opinion on this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] vladimirpetrov commented on issue #4654: VM's name and display name in UI

Posted by GitBox <gi...@apache.org>.

vladimirpetrov commented on issue #4654:
URL: https://github.com/apache/cloudstack/issues/4654#issuecomment-773866435


   I agree with @harikrishna-patnala! 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr edited a comment on issue #4654: VM's name and display name in UI

Posted by GitBox <gi...@apache.org>.

shwstppr edited a comment on issue #4654:
URL: https://github.com/apache/cloudstack/issues/4654#issuecomment-773823098


   @harikrishna-patnala @vladimirpetrov @PaulAngus @weizhouapache @ravening @rhtyd @davidjumani @andrijapanicsb, others: opinion on this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] harikrishna-patnala commented on issue #4654: VM's name and display name in UI

Posted by GitBox <gi...@apache.org>.

harikrishna-patnala commented on issue #4654:
URL: https://github.com/apache/cloudstack/issues/4654#issuecomment-773827166


   @shwstppr In my opinion list view should show "Display Name" of the VM because the displayname itself is meant for that.
   so I would like to see display name instead of name. Details tab anyways shows both Display Name and Name


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] harikrishna-patnala commented on issue #4654: VM's name and display name in UI

Posted by GitBox <gi...@apache.org>.

harikrishna-patnala commented on issue #4654:
URL: https://github.com/apache/cloudstack/issues/4654#issuecomment-773827166


   @shwstppr In my opinion list view should show "Display Name" of the VM because the displayname itself is meant for that.
   so I would like to see display name instead of name. Details tab anyways shows both Display Name and Name


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on issue #4654: VM's name and display name in UI

Posted by GitBox <gi...@apache.org>.

shwstppr commented on issue #4654:
URL: https://github.com/apache/cloudstack/issues/4654#issuecomment-773823098


   @harikrishna-patnala @vladimirpetrov @PaulAngus @weizhouapache @ravening @rhtyd @davidjumani @andrijapanicsb opinion on this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] vladimirpetrov commented on issue #4654: VM's name and display name in UI

Posted by GitBox <gi...@apache.org>.

vladimirpetrov commented on issue #4654:
URL: https://github.com/apache/cloudstack/issues/4654#issuecomment-773866435


   I agree with @harikrishna-patnala! 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on issue #4654: VM's name and display name in UI

Posted by GitBox <gi...@apache.org>.

davidjumani commented on issue #4654:
URL: https://github.com/apache/cloudstack/issues/4654#issuecomment-795177569


   I've created a PR https://github.com/apache/cloudstack/pull/4787 to show the display name in the listview, like the legacy UI.
   Can we discuss what needs to be added / removed there


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on issue #4654: VM's name and display name in UI

Posted by GitBox <gi...@apache.org>.

rhtyd commented on issue #4654:
URL: https://github.com/apache/cloudstack/issues/4654#issuecomment-791906469


   +1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr edited a comment on issue #4654: VM's name and display name in UI

Posted by GitBox <gi...@apache.org>.

shwstppr edited a comment on issue #4654:
URL: https://github.com/apache/cloudstack/issues/4654#issuecomment-773823098


   @harikrishna-patnala @vladimirpetrov @PaulAngus @weizhouapache @ravening @rhtyd @davidjumani @andrijapanicsb, others: opinion on this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on issue #4654: VM's name and display name in UI

Posted by GitBox <gi...@apache.org>.

rhtyd commented on issue #4654:
URL: https://github.com/apache/cloudstack/issues/4654#issuecomment-796568894


   Fixed in https://github.com/apache/cloudstack/pull/4787 for 4.15


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] PaulAngus commented on issue #4654: VM's name and display name in UI

Posted by GitBox <gi...@apache.org>.

PaulAngus commented on issue #4654:
URL: https://github.com/apache/cloudstack/issues/4654#issuecomment-773904289


   I think that the `display name` is the most obvious thing to show as Hari and Vladi say. 
   
   Our problem is that its a UI bug not to show both when creating an instance* so everyone knows what was going on, then the documentation mistakes might not have happened.
   
   _Someone_ will probably get upset if we change it, even though it makes much more sense.
   
   * @shwstppr - We should update the Add Instance wizard in the UI to show both 'name' and 'display name'.
   
   + While we're at it...  Who, _ever_, sets the name of something that they're creating at the END!  (how on earth is the name of the instance just a 'detail').   Can we move the 'name' and 'display name' input fields to the start?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd closed issue #4654: VM's name and display name in UI

Posted by GitBox <gi...@apache.org>.

rhtyd closed issue #4654:
URL: https://github.com/apache/cloudstack/issues/4654


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] PaulAngus commented on issue #4654: VM's name and display name in UI

Posted by GitBox <gi...@apache.org>.

PaulAngus commented on issue #4654:
URL: https://github.com/apache/cloudstack/issues/4654#issuecomment-773904289


   I think that the `display name` is the most obvious thing to show as Hari and Vladi say. 
   
   Our problem is that its a UI bug not to show both when creating an instance* so everyone knows what was going on, then the documentation mistakes might not have happened.
   
   _Someone_ will probably get upset if we change it, even though it makes much more sense.
   
   * @shwstppr - We should update the Add Instance wizard in the UI to show both 'name' and 'display name'.
   
   + While we're at it...  Who, _ever_, sets the name of something that they're creating at the END!  (how on earth is the name of the instance just a 'detail').   Can we move the 'name' and 'display name' input fields to the start?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on issue #4654: VM's name and display name in UI

Posted by GitBox <gi...@apache.org>.

davidjumani commented on issue #4654:
URL: https://github.com/apache/cloudstack/issues/4654#issuecomment-791880666


   @shwstppr I don't have any preferences but can tweak the UI to show both the name and display name on the info card so everyone is happy


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org