You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "hussein-awala (via GitHub)" <gi...@apache.org> on 2023/11/13 22:21:08 UTC

[PR] Add a new config to configure the host of the scheduler health check server [airflow]

hussein-awala opened a new pull request, #35616:
URL: https://github.com/apache/airflow/pull/35616

   For security reasons, using "0.0.0.0" as a host is not a good practice, even for a health check server.
   
   This PR creates a new config to configure the host of the scheduler health check server and uses the existing one as the default value.
   
   related: #35615


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add a new config to configure the host of the scheduler health check server [airflow]

Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala merged PR #35616:
URL: https://github.com/apache/airflow/pull/35616


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add a new config to configure the host of the scheduler health check server [airflow]

Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on code in PR #35616:
URL: https://github.com/apache/airflow/pull/35616#discussion_r1393047898


##########
airflow/config_templates/config.yml:
##########
@@ -2130,6 +2130,14 @@ scheduler:
       type: boolean
       example: ~
       default: "False"
+    scheduler_health_check_server_host:
+      description: |
+        When you start a scheduler, airflow starts a tiny web server
+        subprocess to serve a health check on this host
+      version_added: 2.8.0
+      type: string
+      example: ~
+      default: "0.0.0.0"

Review Comment:
   I thought about it, but I think it's a breaking change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add a new config to configure the host of the scheduler health check server [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #35616:
URL: https://github.com/apache/airflow/pull/35616#discussion_r1393094643


##########
airflow/config_templates/config.yml:
##########
@@ -2130,6 +2130,14 @@ scheduler:
       type: boolean
       example: ~
       default: "False"
+    scheduler_health_check_server_host:
+      description: |
+        When you start a scheduler, airflow starts a tiny web server
+        subprocess to serve a health check on this host
+      version_added: 2.8.0
+      type: string
+      example: ~
+      default: "0.0.0.0"

Review Comment:
   A bit. But we do allow breaking changes "because security" ....



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add a new config to configure the host of the scheduler health check server [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #35616:
URL: https://github.com/apache/airflow/pull/35616#issuecomment-1809260644

   (and nice bandit to tell us so - BTW :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add a new config to configure the host of the scheduler health check server [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #35616:
URL: https://github.com/apache/airflow/pull/35616#discussion_r1393094986


##########
airflow/config_templates/config.yml:
##########
@@ -2130,6 +2130,14 @@ scheduler:
       type: boolean
       example: ~
       default: "False"
+    scheduler_health_check_server_host:
+      description: |
+        When you start a scheduler, airflow starts a tiny web server
+        subprocess to serve a health check on this host
+      version_added: 2.8.0
+      type: string
+      example: ~
+      default: "0.0.0.0"

Review Comment:
   (just saying :D) . Not very strong on it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add a new config to configure the host of the scheduler health check server [airflow]

Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on PR #35616:
URL: https://github.com/apache/airflow/pull/35616#issuecomment-1826412613

   Static checks failure is not related to this PR; I will try to fix it in a separate PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add a new config to configure the host of the scheduler health check server [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #35616:
URL: https://github.com/apache/airflow/pull/35616#discussion_r1391786285


##########
airflow/config_templates/config.yml:
##########
@@ -2130,6 +2130,14 @@ scheduler:
       type: boolean
       example: ~
       default: "False"
+    scheduler_health_check_server_host:
+      description: |
+        When you start a scheduler, airflow starts a tiny web server
+        subprocess to serve a health check on this host
+      version_added: 2.8.0
+      type: string
+      example: ~
+      default: "0.0.0.0"

Review Comment:
   Should the default **continue** to be 0.0.0.0 ? For me it looks like we might choose no default and use IP reverse-dnsed from hostname callable: https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#hostname-callable maybe?). That would be quite a bit more secure default and only slightly risky when it comes to backwards compatibility.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org