You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by il...@apache.org on 2019/09/19 09:03:43 UTC

[dubbo-admin] branch develop updated: fix issue #478: bugs in admin web page

This is an automated email from the ASF dual-hosted git repository.

iluo pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/dubbo-admin.git


The following commit(s) were added to refs/heads/develop by this push:
     new 71bef65  fix issue #478: bugs in admin web page
71bef65 is described below

commit 71bef65796a293ebc743b72afc331aba989e300a
Author: Ian Luo <ia...@gmail.com>
AuthorDate: Thu Sep 19 17:03:21 2019 +0800

    fix issue #478: bugs in admin web page
---
 .../dubbo/admin/service/impl/GenericServiceImpl.java       | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/dubbo-admin-server/src/main/java/org/apache/dubbo/admin/service/impl/GenericServiceImpl.java b/dubbo-admin-server/src/main/java/org/apache/dubbo/admin/service/impl/GenericServiceImpl.java
index eab74de..4677b71 100644
--- a/dubbo-admin-server/src/main/java/org/apache/dubbo/admin/service/impl/GenericServiceImpl.java
+++ b/dubbo-admin-server/src/main/java/org/apache/dubbo/admin/service/impl/GenericServiceImpl.java
@@ -52,16 +52,20 @@ public class GenericServiceImpl {
         ReferenceConfig<GenericService> reference = new ReferenceConfig<>();
         String group = Tool.getGroup(service);
         String version = Tool.getVersion(service);
-        String interfaze = Tool.getInterface(service);
+        String intf = Tool.getInterface(service);
         reference.setGeneric(true);
         reference.setApplication(applicationConfig);
-        reference.setInterface(interfaze);
+        reference.setInterface(intf);
         reference.setVersion(version);
         reference.setGroup(group);
-        removeGenericSymbol(parameterTypes);
-        GenericService genericService = reference.get();
 
-        return genericService.$invoke(method, parameterTypes, params);
+        try {
+            removeGenericSymbol(parameterTypes);
+            GenericService genericService = reference.get();
+            return genericService.$invoke(method, parameterTypes, params);
+        } finally {
+            reference.destroy();
+        }
     }
 
     /**